slack project ts 2019 10 10

2019-10-10

Time	Icon	Name	Message
06:57		U	Hello. I'd like to port vivliostyle-savepdf to TypeScript. almost finished though, is it safe to send a pull request to vivliostyle/vivliostyle-savepdf?
06:59		spring-raining	Sure 👍 I’ll review your PR
08:45		U	@spring-raining Thanks! filed https://github.com/vivliostyle/vivliostyle-savepdf/pull/17 This PR aims to migrate the entire codebase into TypeScript. Summary • yarn/npm build to generate artifacts. • bin/makepdf → src/cli.ts. • lib/*.js → src/lib/*.ts • bin/makepdf <dir> → dist/cli.js <dir>. • or yarn link then makepdf <dir>. Caveat • types/chrome-remote-interface.d.ts covers the least required type definitions. Edit PR freely.
14:03		U	ついでにテスト書いておきました