slack project ts 2019 08 15
| Time | Icon | Name | Message |
|---|---|---|---|
| 09:43 |  |
Johannes Wilm |
@shinyu Should I adjust vivliostyle-print so that doesn't add an extra resources folder? It may just be a change to the documentation. |
| 09:45 | |
Johannes Wilm | currently it adds vivliostyle-viewport-screen.css and vivliostyle-viewport.css from the resources folder. |
| 09:46 | |
Johannes Wilm | and it sets the userAgentRootURL |
| 09:57 | |
Johannes Wilm | hmm, actually, vivliostyle-print next-branch doesn't seem to work at all . it crashed the browser tab. And I can see that it still downloads a lot files from the resources-folder. |
| 10:07 |  |
shinyu | I moved user-agent*.* and validation.txt files from the resources folder to the src/ts/resources/*.ts files, but other files vivliostyle-viewport.css etc. remain in the resources folder and they are loaded from the HTML file. |
| 10:09 | |
Johannes Wilm | Oh ok. I won't make any changes now then. But also without this change, vivliostyle-print currently crashes the browser. |
| 10:26 | |
shinyu | I tested the demo on the vivliostyle-print next branch — I needed modify rollup.demo.config.js in the same way as rollup.config.js (buble -> babel). It seems working. |
| 10:32 | |
shinyu | BTW, I need help about upgrading Gulp 3 to 4 in the vivliostyle-ui project. WIP: upgrade Gulp 3 to 4 https://github.com/vivliostyle/vivliostyle-ui/commit/2ddad8e73a122b26018ba124fd6f577e80f5fe5c with this commit “build” task works, but “serve” task hangs up. What’s wrong? |
| 13:19 | |
Johannes Wilm | I had a second look. I have managed to include those css files directly. The file mathjax-config.js dosn't seem to be referenced anywhere. |
| 13:20 | |
Johannes Wilm |
@shinyu Please let me know if I misunderstood anything about how it is supposed to work, but otherwise I think the vivliostyle-print next branch can be merged and a new release be made |
| 14:05 | |
shinyu |
The file mathjax-config.js dosn’t seem to be referenced anywhere.mathjax-config.js and MathJax.js have to be referenced from the HTML if you need MathJax. See the HTMLs in vivliostyle-ui and vivliostyle-savepdf: https://github.com/vivliostyle/vivliostyle-ui/blob/319a0a1cec0c983e0a1b60a03454a7ea6b8b85c4/src/html/vivliostyle-viewer.ejs#L10-L11 https://github.com/vivliostyle/vivliostyle-savepdf/blob/7b71309fab38859e97026f4df1f133a4e1f3c1d5/broker/index.html#L9-L10 [vivliostyle/vivliostyle-ui] src/html/vivliostyle-viewer.ejs:10-11 [vivliostyle/vivliostyle-savepdf] broker/index.html:9-10 |
| 14:25 | |
Johannes Wilm | Ok, in that case vivliostyle-print is ready for release once vivliostyle.js has been released. |
| 14:27 | |
Johannes Wilm | I have used vivliostyle-print with prerendered formulas using katex and mathlive and without mathjax, and that worked fine. |
| 17:00 | |
shinyu | Resolved: https://github.com/vivliostyle/vivliostyle-ui/commit/c9e92a647900bd5493a2401e8620c8010741c106 |