-
Notifications
You must be signed in to change notification settings - Fork 99
Project Meeting 2022.09.13
mnbina edited this page Sep 22, 2022
·
2 revisions
- Sharrow Time Windows
- Sharrow-version of time windows code has been implemented and produces identical results.
- End result of models running (applied without any other changes to the configuration files) is that it actually runs significantly slower than the pandas-version.
- The reason why: tour scheduling spec file has lines in it that develop coefficients based on tour type. Numba doesn’t accelerate code that does string comparisons, and this file includes many conditional statements (tour_type!==’escort’, for example).
- Jeff developed a code that consolidates string comparisons at the beginning and then using numerical type comparisons later on in order to optimize the file for sharrow. With these significant changes, the runtime is about the same as the pandas version but is still not faster.
- This could be on the list of recommended fixes, in Phase 8, when evaluating data types, to revise this spec file. RSG re-estimated for SEMCOG (and subsequently applied to MWCOG, CMAP, and SANDAG) and doesn’t have this issue, the coefficients are segmented by purpose.
- Scheduling components is when RAM spikes. Switching to numba code provides opportunity to vectorize them instead of temporary arrays, which would reduce the RAM footprint.
- Recommendation for this code to be reviewed, once Jeff makes a few more changes, not 100% ready yet.
Code that needs to be reviewed or about to be reviewed:
- Original Sharrow 1 zone – review is still in progress. David finished his review. Sijia still needs to do some review.
- Sharrow 2 and 3 zones – ready for review
- Flexible number of tours and trips – ready for review
- School escorting – currently under review by Joe Flood
- RSG and WSP out of code review funds and need additional funds to review other sharrow pull requests. Joe to figure out path forward to providing additional funds, likely interim task orders, separate from Phase 8 scoping. CS still has budget but set to expire in November, may need no-cost time-extension.
- ACTION ITEM: Joe to reach out individually to each firm, by Thursday (9/15/2022) with a draft scope and budget.