-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add context to schedule functions #898
Conversation
Codecov Report
@@ Coverage Diff @@
## main #898 +/- ##
==========================================
- Coverage 71.46% 71.42% -0.05%
==========================================
Files 304 304
Lines 12463 12482 +19
==========================================
+ Hits 8907 8915 +8
- Misses 3121 3132 +11
Partials 435 435
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, ty.
might want to add a story to revisit the context.TODO()
s later, but its a great start.
Do you think we should include that work now? Removing the context.TODOs will require us to touch the api/router codebase to pass along the gin context. |
may as well, I suppose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@JordanSussman im fine merging as-is, just let me know |
Add
context.Context
as the first argument to every schedule function.xref: go-vela/community#832