Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add context to pipeline functions #923

Merged
merged 9 commits into from
Aug 17, 2023
Merged

chore: add context to pipeline functions #923

merged 9 commits into from
Aug 17, 2023

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Aug 4, 2023

continuing the efforts started in #898 and #922

directly depends on #922

this is prep to add support for OpenTelemetry tracing.

the reason being, otel can (for the most part) work out of the box if you pass around contexts properly.

@plyr4 plyr4 changed the title enhance/ctx pipeline chore: add context to pipeline functions Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #923 (e86bfff) into main (26aa0b6) will increase coverage by 0.02%.
The diff coverage is 86.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #923      +/-   ##
==========================================
+ Coverage   71.09%   71.11%   +0.02%     
==========================================
  Files         304      304              
  Lines       12520    12529       +9     
==========================================
+ Hits         8901     8910       +9     
  Misses       3177     3177              
  Partials      442      442              
Files Changed Coverage Δ
api/build/create.go 0.00% <0.00%> (ø)
api/build/restart.go 0.00% <0.00%> (ø)
database/pipeline/count.go 100.00% <100.00%> (ø)
database/pipeline/count_repo.go 100.00% <100.00%> (ø)
database/pipeline/create.go 60.00% <100.00%> (ø)
database/pipeline/delete.go 100.00% <100.00%> (ø)
database/pipeline/get.go 70.00% <100.00%> (ø)
database/pipeline/get_repo.go 76.00% <100.00%> (ø)
database/pipeline/index.go 100.00% <100.00%> (ø)
database/pipeline/list.go 66.66% <100.00%> (ø)
... and 7 more

@plyr4 plyr4 marked this pull request as ready for review August 11, 2023 13:00
@plyr4 plyr4 requested a review from a team as a code owner August 11, 2023 13:00
timhuynh94
timhuynh94 previously approved these changes Aug 17, 2023
KellyMerrick
KellyMerrick previously approved these changes Aug 17, 2023
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@plyr4 plyr4 dismissed stale reviews from KellyMerrick and timhuynh94 via 92a5ba5 August 17, 2023 15:09
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants