Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add context to Workers #940

Merged
merged 3 commits into from
Sep 1, 2023
Merged

enhance: add context to Workers #940

merged 3 commits into from
Sep 1, 2023

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Aug 28, 2023

continuing the efforts started in #898 #922 #923 #930 #937 #938

this is prep to add support for OpenTelemetry tracing.

the reason being, otel can (for the most part) work out of the box if you pass around contexts properly.

@plyr4 plyr4 requested a review from a team as a code owner August 28, 2023 14:52
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #940 (5178bf9) into main (a3912ea) will increase coverage by 0.01%.
The diff coverage is 88.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #940      +/-   ##
==========================================
+ Coverage   70.88%   70.89%   +0.01%     
==========================================
  Files         311      311              
  Lines       12871    12881      +10     
==========================================
+ Hits         9123     9132       +9     
- Misses       3283     3284       +1     
  Partials      465      465              
Files Changed Coverage Δ
api/build/cancel.go 0.00% <0.00%> (ø)
router/middleware/executors/executors.go 2.53% <0.00%> (-0.04%) ⬇️
database/resource.go 71.30% <100.00%> (+0.25%) ⬆️
database/worker/count.go 100.00% <100.00%> (ø)
database/worker/create.go 85.00% <100.00%> (ø)
database/worker/delete.go 100.00% <100.00%> (ø)
database/worker/get.go 81.25% <100.00%> (ø)
database/worker/get_hostname.go 83.33% <100.00%> (ø)
database/worker/index.go 100.00% <100.00%> (ø)
database/worker/list.go 72.72% <100.00%> (ø)
... and 5 more

wass3r
wass3r previously approved these changes Aug 30, 2023
wass3rw3rk
wass3rw3rk previously approved these changes Sep 1, 2023
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@plyr4 plyr4 merged commit 38fae72 into main Sep 1, 2023
12 of 13 checks passed
@plyr4 plyr4 deleted the enhance/ctx-worker branch September 1, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants