-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: add context to scm #969
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #969 +/- ##
=======================================
Coverage 70.97% 70.97%
=======================================
Files 312 312
Lines 12922 12922
=======================================
Hits 9172 9172
Misses 3285 3285
Partials 465 465
|
wass3rw3rk
previously approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plyr4
force-pushed
the
enhance/ctx-scm
branch
from
September 18, 2023 21:39
38f6aca
to
b695599
Compare
wass3rw3rk
approved these changes
Sep 18, 2023
wass3rw3rk
requested changes
Sep 18, 2023
wass3rw3rk
approved these changes
Sep 18, 2023
KellyMerrick
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
context.TODO(lgtm)
wass3rw3rk
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuing the efforts started in #898 #922 #923 #930 #937 #938 #941 #942 #950 #951
this is prep to add support for OpenTelemetry tracing.
the reason being, otel can (for the most part) work out of the box if you pass around contexts properly.