Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add context to scm #969

Merged
merged 2 commits into from
Sep 19, 2023
Merged

enhance: add context to scm #969

merged 2 commits into from
Sep 19, 2023

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Sep 18, 2023

continuing the efforts started in #898 #922 #923 #930 #937 #938 #941 #942 #950 #951

this is prep to add support for OpenTelemetry tracing.

the reason being, otel can (for the most part) work out of the box if you pass around contexts properly.

@plyr4 plyr4 requested a review from a team as a code owner September 18, 2023 21:16
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #969 (4d42413) into main (76971f6) will not change coverage.
The diff coverage is 61.01%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #969   +/-   ##
=======================================
  Coverage   70.97%   70.97%           
=======================================
  Files         312      312           
  Lines       12922    12922           
=======================================
  Hits         9172     9172           
  Misses       3285     3285           
  Partials      465      465           
Files Changed Coverage Δ
api/build/create.go 0.00% <0.00%> (ø)
api/build/get_id.go 0.00% <0.00%> (ø)
api/build/list_org.go 0.00% <0.00%> (ø)
api/build/restart.go 0.00% <0.00%> (ø)
api/build/update.go 0.00% <0.00%> (ø)
database/pipeline/pipeline.go 51.72% <ø> (-1.61%) ⬇️
scm/github/github.go 100.00% <ø> (ø)
router/middleware/perm/perm.go 59.12% <36.36%> (+0.09%) ⬆️
scm/github/repo.go 76.99% <76.92%> (ø)
database/build/list_deployment.go 78.57% <100.00%> (ø)
... and 8 more

wass3rw3rk
wass3rw3rk previously approved these changes Sep 18, 2023
Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

context everywhere

cmd/vela-server/schedule.go Outdated Show resolved Hide resolved
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

context.TODO(lgtm)

@plyr4 plyr4 merged commit 7ee3ae3 into main Sep 19, 2023
12 of 13 checks passed
@plyr4 plyr4 deleted the enhance/ctx-scm branch September 19, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants