Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add context to Hooks #938

Merged
merged 6 commits into from
Sep 1, 2023
Merged

enhance: add context to Hooks #938

merged 6 commits into from
Sep 1, 2023

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Aug 25, 2023

continuing the efforts started in #898 #922 #923 #930 #937

this is prep to add support for OpenTelemetry tracing.

the reason being, otel can (for the most part) work out of the box if you pass around contexts properly.

@plyr4 plyr4 requested a review from a team as a code owner August 25, 2023 15:23
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #938 (e631373) into main (46337cf) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #938      +/-   ##
==========================================
+ Coverage   70.86%   70.88%   +0.01%     
==========================================
  Files         311      311              
  Lines       12864    12871       +7     
==========================================
+ Hits         9116     9123       +7     
  Misses       3283     3283              
  Partials      465      465              
Files Changed Coverage Δ
database/hook/count.go 100.00% <100.00%> (ø)
database/hook/count_repo.go 100.00% <100.00%> (ø)
database/hook/create.go 85.71% <100.00%> (ø)
database/hook/delete.go 100.00% <100.00%> (ø)
database/hook/get.go 81.25% <100.00%> (ø)
database/hook/get_repo.go 85.71% <100.00%> (ø)
database/hook/hook.go 51.72% <100.00%> (ø)
database/hook/index.go 100.00% <100.00%> (ø)
database/hook/last_repo.go 70.83% <100.00%> (ø)
database/hook/list.go 72.72% <100.00%> (ø)
... and 5 more

wass3r
wass3r previously approved these changes Aug 30, 2023
@wass3r wass3r dismissed their stale review August 30, 2023 05:16

failing tests

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@plyr4 plyr4 merged commit a3912ea into main Sep 1, 2023
13 checks passed
@plyr4 plyr4 deleted the enhance/ctx-hook branch September 1, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants