-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes 4: Refactor PlainTextContentStorageHandler to use Language object #6448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 17, 2024
bastianallgeier
force-pushed
the
v5/changes/language-type-hinting
branch
from
May 17, 2024 15:23
1c95bdf
to
ea67992
Compare
This was referenced May 21, 2024
bastianallgeier
force-pushed
the
v5/changes/language-type-hinting
branch
from
May 22, 2024 12:26
ea67992
to
dcb5a81
Compare
bastianallgeier
changed the base branch from
v5/develop
to
v5/changes/version-class
May 22, 2024 12:26
13 tasks
bastianallgeier
force-pushed
the
v5/changes/language-type-hinting
branch
from
June 5, 2024 09:04
bc9e8cb
to
8ab215a
Compare
lukasbestle
reviewed
Jun 5, 2024
Co-authored-by: Lukas Bestle <[email protected]>
lukasbestle
reviewed
Jun 5, 2024
Co-authored-by: Lukas Bestle <[email protected]>
Co-authored-by: Lukas Bestle <[email protected]>
lukasbestle
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That all looks very sensible now. 👍
The ContentStorage
class is in a weird limbo now, but as it will get replaced anyway quite soon, it doesn't really matter.
This was referenced Jun 11, 2024
This was referenced Jun 14, 2024
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR …
Refactoring
Language::single()
method to create a Language placeholder object in single language installationsContentStorageHandler
andPlainTextContentStorageHandler
methodsContentStorage
to always provide a full language object to the storage methods. This is only temporary to keep all the unit tests working.ContentStorage
will be removed later, as planned.Outlook
PlainTextContentStorageHandler
class will no longer implement the interface but extend the abstractContentStorageHandler
class. This change will also remove the__construct
method, which will then be implemented by the abstract. Changes 5: ContentStorageHandler Abstract #6449::write
method will later be moved to theContentStorageHandler
class as an abstract method.ContentStorageHandler
will then also get a non-abstract update and create method, which will use the new write method by default. This will add the option for storage handlers to only modify the write method if no further logic is needed for create and update. Changes 10: New MemoryContentStorageHandler #6457Breaking changes
None
Ready?
For review team