Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes 9: Remove content storage class #6456

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

bastianallgeier
Copy link
Member

@bastianallgeier bastianallgeier commented May 21, 2024

This PR …

Refactoring

  • ModelWithContent and all it's children are now using the PlainTextContentStorage class without the wrapping ContentStorage class
  • ContentStorage has been removed
  • Language::create and Language::delete have been fixed

Breaking changes

  • ContentStorage does no longer exist. Since it has been marked as internal, this should not be an issue.

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@bastianallgeier bastianallgeier added this to the 5.0.0-alpha.1 milestone May 21, 2024
@bastianallgeier bastianallgeier force-pushed the v5/changes/remove-content-storage branch from 5fb0aa7 to 5b6f287 Compare May 22, 2024 12:42
@bastianallgeier bastianallgeier changed the base branch from v5/develop to v5/changes/model-version May 22, 2024 12:42
@bastianallgeier bastianallgeier force-pushed the v5/changes/remove-content-storage branch from 5b6f287 to 0ce9960 Compare May 22, 2024 12:43
@bastianallgeier bastianallgeier force-pushed the v5/changes/model-version branch from 0f9107a to 1e395cb Compare June 5, 2024 10:15
@bastianallgeier bastianallgeier force-pushed the v5/changes/remove-content-storage branch from 0ce9960 to 6d90668 Compare June 5, 2024 10:33
@bastianallgeier bastianallgeier force-pushed the v5/changes/model-version branch from ab78bed to 2cfcabc Compare June 11, 2024 10:15
@bastianallgeier bastianallgeier force-pushed the v5/changes/remove-content-storage branch 2 times, most recently from 990f8b5 to af2e3d2 Compare June 11, 2024 14:15
@bastianallgeier bastianallgeier force-pushed the v5/changes/model-version branch from 2cfcabc to 25994e3 Compare June 11, 2024 14:15
@bastianallgeier bastianallgeier force-pushed the v5/changes/model-version branch from 25994e3 to 814f8c7 Compare June 13, 2024 09:16
@bastianallgeier bastianallgeier force-pushed the v5/changes/remove-content-storage branch from af2e3d2 to 4654849 Compare June 13, 2024 09:18
src/Cms/Language.php Outdated Show resolved Hide resolved
@bastianallgeier bastianallgeier force-pushed the v5/changes/model-version branch from 814f8c7 to 0626fea Compare June 17, 2024 09:01
@bastianallgeier bastianallgeier force-pushed the v5/changes/remove-content-storage branch from 4654849 to db198ee Compare June 17, 2024 09:36
Base automatically changed from v5/changes/model-version to v5/develop June 18, 2024 19:51
@lukasbestle lukasbestle marked this pull request as ready for review June 18, 2024 19:51
@lukasbestle lukasbestle merged commit 1ace957 into v5/develop Jun 18, 2024
11 checks passed
@lukasbestle lukasbestle deleted the v5/changes/remove-content-storage branch June 18, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants