-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes 9: Remove content storage class #6456
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2024
bastianallgeier
force-pushed
the
v5/changes/remove-content-storage
branch
from
May 22, 2024 12:42
5fb0aa7
to
5b6f287
Compare
bastianallgeier
changed the base branch from
v5/develop
to
v5/changes/model-version
May 22, 2024 12:42
bastianallgeier
force-pushed
the
v5/changes/remove-content-storage
branch
from
May 22, 2024 12:43
5b6f287
to
0ce9960
Compare
13 tasks
bastianallgeier
force-pushed
the
v5/changes/model-version
branch
from
June 5, 2024 10:15
0f9107a
to
1e395cb
Compare
bastianallgeier
force-pushed
the
v5/changes/remove-content-storage
branch
from
June 5, 2024 10:33
0ce9960
to
6d90668
Compare
bastianallgeier
force-pushed
the
v5/changes/model-version
branch
from
June 11, 2024 10:15
ab78bed
to
2cfcabc
Compare
bastianallgeier
force-pushed
the
v5/changes/remove-content-storage
branch
2 times, most recently
from
June 11, 2024 14:15
990f8b5
to
af2e3d2
Compare
bastianallgeier
force-pushed
the
v5/changes/model-version
branch
from
June 11, 2024 14:15
2cfcabc
to
25994e3
Compare
This was referenced Jun 11, 2024
bastianallgeier
force-pushed
the
v5/changes/model-version
branch
from
June 13, 2024 09:16
25994e3
to
814f8c7
Compare
bastianallgeier
force-pushed
the
v5/changes/remove-content-storage
branch
from
June 13, 2024 09:18
af2e3d2
to
4654849
Compare
This was referenced Jun 14, 2024
lukasbestle
reviewed
Jun 16, 2024
bastianallgeier
force-pushed
the
v5/changes/model-version
branch
from
June 17, 2024 09:01
814f8c7
to
0626fea
Compare
bastianallgeier
force-pushed
the
v5/changes/remove-content-storage
branch
from
June 17, 2024 09:36
4654849
to
db198ee
Compare
lukasbestle
approved these changes
Jun 18, 2024
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR …
Refactoring
ModelWithContent
and all it's children are now using thePlainTextContentStorage
class without the wrappingContentStorage
classContentStorage
has been removedLanguage::create
andLanguage::delete
have been fixedBreaking changes
ContentStorage
does no longer exist. Since it has been marked as internal, this should not be an issue.Ready?
For review team