Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes 16: ModelWithContent simplifications #6504

Conversation

bastianallgeier
Copy link
Member

This PR …

Reasoning

I'm trying to already use the improvements and changes from the last PRs in ModelWithContent without taking too many steps at once. The full conversion will be still a lot of complicated, potentially breaking steps. Taking it easy will help to keep our mental load in check.

Refactoring

  • Simplify ModelWithContent::writeContent by using the new Version::save() method.

Breaking changes

None expected

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@bastianallgeier bastianallgeier deleted the v5/changes/16-model-with-content-simplification branch June 25, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant