-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes 8: New ModelWithContent::version method #6455
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 21, 2024
bastianallgeier
force-pushed
the
v5/changes/model-version
branch
from
May 22, 2024 12:38
9a3fd8e
to
0f9107a
Compare
bastianallgeier
changed the base branch from
v5/develop
to
v5/changes/move-content-storage-methods
May 22, 2024 12:38
13 tasks
bastianallgeier
force-pushed
the
v5/changes/move-content-storage-methods
branch
from
June 5, 2024 10:11
238b762
to
006e269
Compare
bastianallgeier
force-pushed
the
v5/changes/model-version
branch
from
June 5, 2024 10:15
0f9107a
to
1e395cb
Compare
bastianallgeier
force-pushed
the
v5/changes/move-content-storage-methods
branch
from
June 11, 2024 10:11
006e269
to
e21848a
Compare
bastianallgeier
force-pushed
the
v5/changes/model-version
branch
from
June 11, 2024 10:15
ab78bed
to
2cfcabc
Compare
bastianallgeier
force-pushed
the
v5/changes/move-content-storage-methods
branch
from
June 11, 2024 14:15
e21848a
to
df52ad8
Compare
bastianallgeier
force-pushed
the
v5/changes/model-version
branch
from
June 11, 2024 14:15
2cfcabc
to
25994e3
Compare
This was referenced Jun 11, 2024
bastianallgeier
force-pushed
the
v5/changes/move-content-storage-methods
branch
from
June 13, 2024 07:56
df52ad8
to
d949cff
Compare
bastianallgeier
force-pushed
the
v5/changes/model-version
branch
from
June 13, 2024 09:16
25994e3
to
814f8c7
Compare
This was referenced Jun 14, 2024
Base automatically changed from
v5/changes/move-content-storage-methods
to
v5/develop
June 16, 2024 18:40
lukasbestle
reviewed
Jun 16, 2024
bastianallgeier
force-pushed
the
v5/changes/model-version
branch
from
June 17, 2024 09:01
814f8c7
to
0626fea
Compare
Co-authored-by: Lukas Bestle <[email protected]>
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR …
Features
ModelWithContent::version()
methodRefactoring
ModelWithContent::convertTo
ModelWithContent::readContent
ModelWithContent::writeContent
File::modifiedContent
Page::modified
System::exposedFileUrl
User::exists
User::modified
ContentTranslation::contentFile
FileActionsTest
PageActionsTest
The other methods are hard to test for the abstract class. We should probably add tests for the PlainTextContentStorageHandler class but so far all those tests have been missing anyway.
Breaking changes
ModelWithContent::version()
is now a reserved keyword. If you've used a field with this name, you need to use$model->content()->get('version')
instead to work with the field.Page::modified()
,File::modifiedContent()
andUser::modified()
now use the current language instead of the default language.Ready?
For review team