-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes 14: Model prop fixes #6499
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastianallgeier
force-pushed
the
v5/changes/13-new-translation-classes
branch
from
June 20, 2024 09:33
4648e2a
to
8f94357
Compare
bastianallgeier
force-pushed
the
v5/changes/14-prop-fixes
branch
from
June 20, 2024 09:34
cc14091
to
0bca337
Compare
bastianallgeier
force-pushed
the
v5/changes/13-new-translation-classes
branch
from
June 20, 2024 09:47
8f94357
to
84cdf0a
Compare
bastianallgeier
force-pushed
the
v5/changes/14-prop-fixes
branch
from
June 20, 2024 09:47
0bca337
to
a98b2fb
Compare
18 tasks
bastianallgeier
force-pushed
the
v5/changes/13-new-translation-classes
branch
from
June 21, 2024 09:34
84cdf0a
to
c62e360
Compare
bastianallgeier
force-pushed
the
v5/changes/14-prop-fixes
branch
from
June 21, 2024 09:34
a98b2fb
to
16c3da1
Compare
bastianallgeier
force-pushed
the
v5/changes/13-new-translation-classes
branch
from
June 21, 2024 10:20
c62e360
to
78b12f5
Compare
bastianallgeier
force-pushed
the
v5/changes/14-prop-fixes
branch
from
June 21, 2024 10:20
16c3da1
to
a35cc52
Compare
lukasbestle
approved these changes
Jun 22, 2024
bastianallgeier
force-pushed
the
v5/changes/13-new-translation-classes
branch
from
June 24, 2024 09:29
78b12f5
to
241501d
Compare
bastianallgeier
force-pushed
the
v5/changes/14-prop-fixes
branch
2 times, most recently
from
June 24, 2024 10:04
aa92112
to
b36eef8
Compare
bastianallgeier
force-pushed
the
v5/changes/14-prop-fixes
branch
from
June 25, 2024 08:39
b36eef8
to
e0acee4
Compare
19 tasks
Base automatically changed from
v5/changes/13-new-translation-classes
to
v5/develop
June 27, 2024 08:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR …
Reasoning
Our Models run
parent::__construct
before setting their props. This leads to a situation where::setContent
and::setTranslations
cannot access vital properties, such asisDraft
,slug
,id
etc. because they are not available yet. We cannot properly switch to the Version implementation as long as this is not fixed.Refactoring
Page::__construct
callsparent::__construct
after setting the propsSite::__construct
callsparent::__construct
after setting the propsUser::__construct
callsparent::__construct
after setting the propsFile::__construct
callsparent::__construct
after setting the propsBreaking changes
None expected
Ready?
For review team