-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes 10: New MemoryContentStorageHandler #6457
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2024
This comment was marked as outdated.
This comment was marked as outdated.
bastianallgeier
force-pushed
the
v5/changes/memory-storage-handler
branch
from
May 22, 2024 12:53
5c068b0
to
830c673
Compare
bastianallgeier
changed the base branch from
v5/develop
to
v5/changes/remove-content-storage
May 22, 2024 12:53
This comment was marked as outdated.
This comment was marked as outdated.
bastianallgeier
force-pushed
the
v5/changes/remove-content-storage
branch
from
June 5, 2024 10:33
0ce9960
to
6d90668
Compare
bastianallgeier
force-pushed
the
v5/changes/memory-storage-handler
branch
from
June 5, 2024 10:36
5ed3059
to
524947f
Compare
bastianallgeier
force-pushed
the
v5/changes/remove-content-storage
branch
from
June 11, 2024 10:17
6d90668
to
990f8b5
Compare
bastianallgeier
force-pushed
the
v5/changes/memory-storage-handler
branch
from
June 11, 2024 10:19
524947f
to
b8c2327
Compare
bastianallgeier
force-pushed
the
v5/changes/remove-content-storage
branch
from
June 11, 2024 14:15
990f8b5
to
af2e3d2
Compare
bastianallgeier
force-pushed
the
v5/changes/memory-storage-handler
branch
from
June 11, 2024 14:15
b8c2327
to
147e4b1
Compare
This was referenced Jun 11, 2024
bastianallgeier
force-pushed
the
v5/changes/remove-content-storage
branch
from
June 13, 2024 09:18
af2e3d2
to
4654849
Compare
bastianallgeier
force-pushed
the
v5/changes/memory-storage-handler
branch
from
June 13, 2024 09:18
147e4b1
to
0783387
Compare
This was referenced Jun 14, 2024
bastianallgeier
force-pushed
the
v5/changes/remove-content-storage
branch
from
June 17, 2024 09:36
4654849
to
db198ee
Compare
bastianallgeier
force-pushed
the
v5/changes/memory-storage-handler
branch
from
June 17, 2024 09:39
0783387
to
07885e3
Compare
bastianallgeier
force-pushed
the
v5/changes/memory-storage-handler
branch
from
June 19, 2024 10:45
07885e3
to
31c40ea
Compare
lukasbestle
reviewed
Jun 19, 2024
Co-authored-by: Lukas Bestle <[email protected]>
This was referenced Jun 20, 2024
lukasbestle
reviewed
Jun 21, 2024
bastianallgeier
force-pushed
the
v5/changes/memory-storage-handler
branch
from
June 24, 2024 08:35
2261261
to
4c116b3
Compare
lukasbestle
approved these changes
Jun 24, 2024
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR …
Features
MemoryContentStorageHandler
class (see outlook for details what this class is supposed to do)Refactor
::write
and::ensure
intoContentStorageHandler
class and make them abstractContentStorageHandler::update
andContentStorageHandler::create
into non-abstract methods that use::write
under the hood.ContentStorageHandler::ensure
inVersion::ensure
Outlook
MemoryContentStorageHandler
class will be used inModelWithContent::setContent
andModelWithContent::setTranslation
. It will replace thePlainTextContentStorageHandler
instance with an in-memory version of the content or translation that is passed via array. This will (hopefully) keep our virtual pages, files and users working, while still making use of the underlying storage implementation. It should also help to untie the content vs. translations knot.Breaking changes
None
Ready?
For review team