feat: HCS Wizard Widget with useq WellPlatePlan #308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlambert03
reviewed
Jul 6, 2024
tlambert03
reviewed
Jul 6, 2024
tlambert03
reviewed
Jul 6, 2024
tlambert03
reviewed
Jul 6, 2024
|
coming along! I'm going to do some direct edits this morning and will make a PR to this branch, so hold off on making many changes for a little bit if possible :) |
|
ok @tlambert03 , I merged all the changes from #314 and fixed tests. |
|
great! Now have a look at #315 and merge that when ready |
This was referenced Jul 9, 2024
|
superceded by #360 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a smaller version of #304 that already takes in consideration some of the suggestions and uses the new
useq.WellPlatePlan.Here we add the
HCSWizardbut at the moment we cannot update/modify the plate database (the widget is using a default one). In addition, theHCSWizardis not yet linked to theMDAWidget, it only output auseq.WellPlatePlan.I think it is easier to start from this and add the database and
MDAWidgetlink later on.