Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Points plan selector #315

Merged
merged 23 commits into from
Jul 7, 2024

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Jul 7, 2024

this pulls out the left half of the FOV selector into a useq widget whose value is one of a number of relative point plans. Next step is to put it back into a joint widget with the view on the right side, connect it's valueChanged to update the view

(this is modified from @fdrgsp's code in #308 and he is marked as author in the git history)

@tlambert03 tlambert03 requested a review from fdrgsp July 7, 2024 20:10
Copy link

codecov bot commented Jul 7, 2024

Codecov Report

Attention: Patch coverage is 93.02326% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.06%. Comparing base (f04ac7e) to head (2c33634).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
...useq_widgets/points_plans/_points_plan_selector.py 92.59% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
+ Coverage   90.03%   90.06%   +0.02%     
==========================================
  Files          70       71       +1     
  Lines        7837     7919      +82     
==========================================
+ Hits         7056     7132      +76     
- Misses        781      787       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fdrgsp
Copy link
Collaborator

fdrgsp commented Jul 7, 2024

@tlambert03 can we make the single FOV text bold and centered as random points and grid? and Is it ok to have all of them in a QGroupBox?

@tlambert03
Copy link
Member Author

yep!

@tlambert03
Copy link
Member Author

just a moment

Copy link
Collaborator

@fdrgsp fdrgsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@tlambert03
Copy link
Member Author

all set

@fdrgsp
Copy link
Collaborator

fdrgsp commented Jul 7, 2024

@tlambert03 ready to merge?

@tlambert03
Copy link
Member Author

yep!

@fdrgsp fdrgsp merged commit 4c51583 into pymmcore-plus:main Jul 7, 2024
20 checks passed
@tlambert03 tlambert03 deleted the points-plan-selector branch July 7, 2024 20:52
@tlambert03 tlambert03 added the enhancement New feature or request label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants