-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Points plan selector #315
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
==========================================
+ Coverage 90.03% 90.06% +0.02%
==========================================
Files 70 71 +1
Lines 7837 7919 +82
==========================================
+ Hits 7056 7132 +76
- Misses 781 787 +6 ☔ View full report in Codecov by Sentry. |
@tlambert03 can we make the |
yep! |
just a moment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
all set |
@tlambert03 ready to merge? |
yep! |
this pulls out the left half of the FOV selector into a useq widget whose value is one of a number of relative point plans. Next step is to put it back into a joint widget with the view on the right side, connect it's valueChanged to update the view
(this is modified from @fdrgsp's code in #308 and he is marked as author in the git history)