Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add useq.WellPlanPlan widget with well selection #318

Merged
merged 16 commits into from
Jul 12, 2024

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Jul 9, 2024

minimal working example of a plate selector extracted from @fdrgsp's code in #308

Screenshot 2024-07-11 at 4 59 25 PM

😂

TODO:

  • add back well names
  • support selection

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 98.01980% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.54%. Comparing base (370dfcd) to head (d8f76c1).
Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
...ymmcore_widgets/useq_widgets/_well_plate_widget.py 98.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #318      +/-   ##
==========================================
+ Coverage   90.36%   90.54%   +0.18%     
==========================================
  Files          73       74       +1     
  Lines        8135     8336     +201     
==========================================
+ Hits         7351     7548     +197     
- Misses        784      788       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 marked this pull request as ready for review July 10, 2024 20:03
@tlambert03 tlambert03 changed the title Plate selector feat: add useq.WellPlanPlan widget with well selection Jul 11, 2024
@tlambert03
Copy link
Member Author

all yours @fdrgsp

@fdrgsp fdrgsp merged commit 426baf2 into pymmcore-plus:main Jul 12, 2024
18 of 20 checks passed
@tlambert03 tlambert03 added the enhancement New feature or request label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants