-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add minimal Points plan view #316
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
==========================================
+ Coverage 90.07% 90.36% +0.28%
==========================================
Files 71 73 +2
Lines 7930 8135 +205
==========================================
+ Hits 7143 7351 +208
+ Misses 787 784 -3 ☔ View full report in Codecov by Sentry. |
pymmcore-widgets/src/pymmcore_widgets/useq_widgets/points_plans/_points_plan_selector.py Lines 132 to 145 in 4c51583
I think at the end here we need to add
no it does not :) |
added a line , and made it so that if the plan can't generate enough points, it suppresses the usual warning and just caps the widget Untitled.mov |
ok, i think this is getting closer. remaining issues above are
i think the first point can come later, the second is also optional. @fdrgsp, if you want to take a more critical look here at what has been done (knowing we can add more in future PRs) that would be great |
ok, I think all the things I wanted to deal with (besides tests) are now dealt with. Take another go at using it, and let me know how it feels. then I'll bring over the tests you wrote for this part, and fix them to work with any changes |
ok, tests added. Assuming they pass, feel free to merge this when ready @fdrgsp, and add the further improvements in a followup |
borrowed and modified from #308
hey @fdrgsp, rather than editing each line of the existing FOVSelector, I decided to pull out the bits that I understood and make a bare minimal working widget. I'm sure that there are some features being missed here, but we can add them back as you point them out (lets be relatively strict about features though).
the main thing I did here was just to allow the GraphicsScene to use real-world coordinates. the qgraphics framework provides all sorts of conveniences in mapping between coordinate frames of the view and the scene, so to me it seems to make a lot of sense just to place the scene in the "real world" (using microns, just as useq schema positions will use), and then adjust the view as needed. (pen size is the one annoying thing here, it works as is here, but i think that could also be smarter... need to read more qt docs). I'll try to add bullet points of things that I know i've removed, and we can add them back, but you can also start a bulleted list as well.
would be great if you could play with this and tell me what you see
_well_width_um