Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multi point plan useq widgets #314

Merged
merged 9 commits into from
Jul 7, 2024

Conversation

tlambert03
Copy link
Member

I'm pulling out the widgets that create multi-points plans from #308, for ease of discussion and testing

Copy link

codecov bot commented Jul 7, 2024

Codecov Report

Attention: Patch coverage is 90.50279% with 17 lines in your changes missing coverage. Please review.

Project coverage is 90.03%. Comparing base (6d088a7) to head (9ed073e).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
...useq_widgets/points_plans/_random_points_widget.py 88.88% 9 Missing ⚠️
...eq_widgets/points_plans/_grid_row_column_widget.py 89.87% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
+ Coverage   90.01%   90.03%   +0.02%     
==========================================
  Files          67       70       +3     
  Lines        7681     7837     +156     
==========================================
+ Hits         6914     7056     +142     
- Misses        767      781      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03
Copy link
Member Author

tlambert03 commented Jul 7, 2024

@fdrgsp, you can merge this one after having a look at it, then resolve conflicts with #308. Note that i made the two widgets regular QWidgets here, so you should insert them into a QGroupBox inside your FOV widget if you want them to have a border

(it's ok to leave in the temporary dependency on useq-schema main)

@fdrgsp fdrgsp merged commit f04ac7e into pymmcore-plus:main Jul 7, 2024
20 checks passed
@tlambert03 tlambert03 added the enhancement New feature or request label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants