[difftest] Add offline difftest and refactor libspike interfaces #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Avimitin please add it to build system and run all elf to check the correctness of this program. |
Avimitin
force-pushed
the
offline-difftest
branch
5 times, most recently
from
7e15390 to
91b98b5
Compare
Clo91eaf
force-pushed
the
offline-difftest
branch
2 times, most recently
from
eaf9627 to
b03f146
Compare
Clo91eaf
force-pushed
the
offline-difftest
branch
from
3231db7 to
ca2a4a9
Compare
Avimitin
force-pushed
the
offline-difftest
branch
2 times, most recently
from
b32b2d2 to
34310a0
Compare
Clo91eaf
force-pushed
the
offline-difftest
branch
3 times, most recently
from
1a766cf to
f552046
Compare
Avimitin
force-pushed
the
offline-difftest
branch
from
f552046 to
d968503
Compare
Clo91eaf
force-pushed
the
offline-difftest
branch
4 times, most recently
from
5871d97 to
87c601a
Compare
sequencer
previously approved these changes
Jun 11, 2024
| @@ -22,10 +22,10 @@ spike_state_t* proc_get_state(spike_processor_t* proc); | |||
|
|
|||
There was a problem hiding this comment.
Please add documentation to header files.
There was a problem hiding this comment.
And please think a question:
if we are going to use sail/qemu to replace spike in the future, how do we decouple this?
maybe riscv_architecture_events.h
| @@ -0,0 +1,11 @@ | |||
| ## Build | |||
There was a problem hiding this comment.
Please add more detail readme on the difftest, including the rational.md.
- the architecture of the difftest design.
- the public interface and usage of the difftest, aka the schema of all events.
Please do it in the following PR.
| let event = self.dut.step()?; | ||
|
|
||
| match &*event.event { | ||
| "peekTL" => { |
There was a problem hiding this comment.
In the following PR, please rename it to "memoryWrite", in the next architecture change, we will refactor T1 to AXI.
| let cycle = event.parameter.cycle.unwrap(); | ||
| self.peek_issue(IssueEvent { idx, cycle }).unwrap(); | ||
| } | ||
| "lsuEnq" => { |
There was a problem hiding this comment.
This should be refactor to RTL w/ tagging.
| let cycle = event.parameter.cycle.unwrap(); | ||
| self.update_lsu_idx(LsuEnqEvent { enq, cycle }).unwrap(); | ||
| } | ||
| "vrfWriteFromLsu" => { |
There was a problem hiding this comment.
It should be merged w/ vrfWriteFromLane
| }) | ||
| .unwrap(); | ||
| } | ||
| "issue" => { |
| }) | ||
| .unwrap(); | ||
| } | ||
| "inst" => { |
Clo91eaf
force-pushed
the
offline-difftest
branch
from
87c601a to
f119fb2
Compare
Avimitin
force-pushed
the
offline-difftest
branch
3 times, most recently
from
f63e4b1 to
270d56d
Compare
Clo91eaf
force-pushed
the
offline-difftest
branch
4 times, most recently
from
03c17ef to
61577cd
Compare
Avimitin
force-pushed
the
offline-difftest
branch
from
d9fdf97 to
e11fd42
Compare
Signed-off-by: Avimitin <[email protected]>
Signed-off-by: Avimitin <[email protected]>
Signed-off-by: Avimitin <[email protected]>
This commit allow sharing same emu logic across multiple test case builder. Signed-off-by: Avimitin <[email protected]>
Signed-off-by: Avimitin <[email protected]>
Signed-off-by: Avimitin <[email protected]>
Avimitin
force-pushed
the
offline-difftest
branch
3 times, most recently
from
ff0016a to
6aa7b46
Compare
Avimitin
force-pushed
the
offline-difftest
branch
from
6aa7b46 to
b432c51
Compare
- Use nix derivation to cache and capture emulator output - Use built-in S3 nix cache to replace GitHub Artifacts - Produce GitHub step summary in Scala script Signed-off-by: Avimitin <[email protected]>
Signed-off-by: Avimitin <[email protected]>
Avimitin
force-pushed
the
offline-difftest
branch
from
b432c51 to
7f20bf4
Compare
sequencer
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.