Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update robust-toolbox/commands.ftl #1604

Merged
merged 7 commits into from
Jun 1, 2024
Merged

Update robust-toolbox/commands.ftl #1604

merged 7 commits into from
Jun 1, 2024

Conversation

XCy4
Copy link
Contributor

@XCy4 XCy4 commented Nov 29, 2023 •
edited
Loading

Описание PR

Локализация на русский язык robust-toolbox/commands, закончена на 99%
Медиа

Проверки

  • [+] PR полностью завершён и мне не нужна помощь чтобы его закончить.
  • [+] Я внимательно просмотрел все свои изменения и багов в них не нашёл.
  • Я запускал локальный сервер со своими изменениями и всё протестировал.
  • [+] Я добавил скриншот/видео демонстрации PR в игре, или этот PR этого не требует.

Изменения

🆑

  • add: Добавлена локализация на русский язык в robust-toolbox/commands

@XCy4
Update robust-toolbox/commands.ftl
dc0968a 
Локализация на русский язык robust-toolbox/commands, закончена на 99%
@XCy4 XCy4 requested a review from ficcialfaint as a code owner November 29, 2023 07:03
@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation Changes: No C# Code has not been changed labels Nov 29, 2023
@mhamsterr
Copy link
Contributor

CL это то что могут видеть игроки в игре. Точно ли им нужно знать об обновлении локализации админ-команд?

@lzk228
Copy link
Collaborator

lzk228 commented Nov 29, 2023

cl не видит даже бот который делает чейнжлог

lzk228
lzk228 requested changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@lzk228 lzk228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

все verbs в указательной форме сделай инфинитивами

Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
@XCy4
Copy link
Contributor Author

XCy4 commented Nov 29, 2023

принял

lzk228
lzk228 previously approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@lzk228 lzk228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

это поправить и мне норм, дальше лапатисон если захочет тоже проверит

Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
@XCy4
Copy link
Contributor Author

XCy4 commented Nov 30, 2023

cmd-gcf-desc = Запускает GC, полную, со сжатием 'кучи больших объектов' (LOH-compacting) и всего.
это прошлый человек, ошибка объект

@XCy4
Copy link
Contributor Author

XCy4 commented Nov 30, 2023 •
edited
Loading

надо ещё до моих изменений проверять
21 Использование: help [имя команды]
получается тоже после использование в квадратных переводить?

ficcialfaint
ficcialfaint previously requested changes Dec 16, 2023
View reviewed changes
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
Resources/Locale/ru-RU/robust-toolbox/commands.ftl Outdated Show resolved Hide resolved
@ficcialfaint ficcialfaint added Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged and removed Status: Needs Review This PR requires new reviews before it can be merged labels Dec 16, 2023
@XCy4 XCy4 requested a review from ficcialfaint December 17, 2023 02:17
@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged and removed Status: Awaiting Changes This PR needs its reviews addressed or changes to be made in order to be merged labels Dec 17, 2023
@lzk228
Copy link
Collaborator

lzk228 commented Jan 31, 2024

@ficcialfaint твоё ревью принято, ревьювь ещё раз

@lzk228
Copy link
Collaborator

lzk228 commented Apr 23, 2024

@lapatison

@lzk228 lzk228 removed the request for review from ficcialfaint June 1, 2024 07:53
@lzk228 lzk228 merged commit ec14df7 into space-syndicate:master Jun 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SonicHDC SonicHDC SonicHDC left review comments

@lzk228 lzk228 lzk228 approved these changes

@ficcialfaint ficcialfaint ficcialfaint left review comments

Assignees
No one assigned
Labels
Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation Changes: No C# Code has not been changed Status: Needs Review This PR requires new reviews before it can be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XCy4 @mhamsterr @lzk228 @ficcialfaint @SonicHDC