-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(utils)!: make snark-artifacts utility functions dynamic #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedoor
force-pushed
the
refactor/dynamic-snark-artifacts
branch
from
April 25, 2024 17:43
dab0511
to
9138e37
Compare
sripwoud
reviewed
Apr 26, 2024
@sripwoud I have deliberately over-minimized those functions ta make them simpler and project-agnostic, but it makes sense to re-integrate parts of your code now. Let's discuss them! |
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a first step to make the utility functions to get snark artifacts more dynamic, i.e. less independent from changes in the
snark-artifacts
repository. As mentioned in this PR's comments the code related to these functions will be moved to another package in thesnark-artifacts
repo. Further checks on parameters could be added in the next step.Comments have not been added as this code will be moved to another package as mentioned above.
Related Issue(s)
Closes #272
Checklist
yarn style
without getting any errors