Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(utils)!: make snark-artifacts utility functions dynamic #275

Merged
merged 5 commits into from
May 14, 2024

Conversation

cedoor
Copy link
Member

@cedoor cedoor commented Apr 25, 2024

Description

This PR is a first step to make the utility functions to get snark artifacts more dynamic, i.e. less independent from changes in the snark-artifacts repository. As mentioned in this PR's comments the code related to these functions will be moved to another package in the snark-artifacts repo. Further checks on parameters could be added in the next step.

Comments have not been added as this code will be moved to another package as mentioned above.

Related Issue(s)

Closes #272

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run yarn style without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cedoor cedoor force-pushed the refactor/dynamic-snark-artifacts branch from dab0511 to 9138e37 Compare April 25, 2024 17:43
packages/eddsa-proof/src/generate.ts Outdated Show resolved Hide resolved
packages/eddsa-proof/src/generate.ts Show resolved Hide resolved
packages/poseidon-proof/src/generate.ts Outdated Show resolved Hide resolved
packages/utils/src/types/index.ts Show resolved Hide resolved
packages/utils/src/types/index.ts Outdated Show resolved Hide resolved
packages/poseidon-proof/tests/index.test.ts Show resolved Hide resolved
@cedoor
Copy link
Member Author

cedoor commented Apr 26, 2024

@sripwoud I have deliberately over-minimized those functions ta make them simpler and project-agnostic, but it makes sense to re-integrate parts of your code now. Let's discuss them!

@cedoor cedoor marked this pull request as ready for review May 7, 2024 13:19
@cedoor cedoor requested a review from sripwoud May 7, 2024 13:36
@cedoor cedoor merged commit 2505199 into main May 14, 2024
4 of 5 checks passed
@cedoor cedoor deleted the refactor/dynamic-snark-artifacts branch May 14, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make functions to get SNARK artifacts more dynamic
2 participants