Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check integrity of snark artifacts #11

Open
cedoor opened this issue Apr 18, 2024 · 4 comments
Open

Check integrity of snark artifacts #11

cedoor opened this issue Apr 18, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@cedoor
Copy link
Member

cedoor commented Apr 18, 2024

Description

After downloading the wasm/zkey files to generate valid proofs, it will be necessary to verify that those files are authentic. There are theoretically two checks to be made:

  1. Check that the downloaded files are the same ones that were uploaded to NPM,
  2. Verify that the downloaded files were generated by a specific trusted-setup.

It is necessary to understand what we need to do for each of these checks, and whether 2 somehow makes 1 redundant.

It is also necessary to understand when to have these checks.

It'll probably make sense to add a README file to each package with the instructions needed to perform these checks, with the correct versions of the packages to be used, or with scripts to simplify the process.

@cedoor cedoor converted this from a draft issue Apr 18, 2024
@cedoor cedoor added the enhancement New feature or request label Apr 18, 2024
@cedoor cedoor moved this from 📋 Backlog to ♻️ Grooming in SNARK Artifacts Apr 18, 2024
@sripwoud
Copy link
Member

For 2.
I'll discuss it with the p0tion team

@sripwoud
Copy link
Member

sripwoud commented Apr 29, 2024

@cedoor should we have an additional package there?
I mean besides the @zk-kit/*-artifacts packages that only contain artifacts?
a package that would become a dep in @zk-kit/utils and provide:

@cedoor
Copy link
Member Author

cedoor commented May 1, 2024

@sripwoud What about creating a new @zk-kit/artifacts package with:

How does it sound?

@cedoor
Copy link
Member Author

cedoor commented May 3, 2024

Privately agreed on creating such a package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: ♻️ Grooming
Development

No branches or pull requests

2 participants