Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in the production and pull-requests workflows #280

Closed
vplasencia opened this issue May 1, 2024 · 1 comment · Fixed by #294
Closed

Error in the production and pull-requests workflows #280

vplasencia opened this issue May 1, 2024 · 1 comment · Fixed by #294
Assignees
Labels
bug 🐛 Something isn't working

Comments

@vplasencia vplasencia added the bug 🐛 Something isn't working label May 1, 2024
@sripwoud
Copy link
Member

sripwoud commented May 3, 2024

@cedoor and I are aware of this.

See #273 (comment)

The main root cause is that the single CDN we currently use to download the artifacts is throttling downloads. This happens especially when automating downloading artifacts concurrently.
2 already on going actions to solve this:

  1. use multiple CDNs and retry fetch mechanism: see feat(utils): use multiple sources to download snark artifacts #273 and refactor(utils)!: make snark-artifacts utility functions dynamic #275 (comment)
  2. In the tests for the -proof packages, we should stop testing ALL the parameters cases (e.g poseidon for 2,3...16 inputs). This requires downloading all the artifacts which takes too long. Most importantly testing the correct proof generation for different parameters is in the scope of the circuit package, not the *-proof packages. See refactor(utils)!: make snark-artifacts utility functions dynamic #275 (comment)

@cedoor cedoor added this to ZK-Kit May 10, 2024
@cedoor cedoor moved this to 🏗 In Progress in ZK-Kit May 10, 2024
sripwoud added a commit that referenced this issue Jun 3, 2024
@sripwoud sripwoud moved this from 🏗 In Progress to 👀 In Review in ZK-Kit Jun 3, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✔️ Done in ZK-Kit Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
Status: ✔️ Done
Development

Successfully merging a pull request may close this issue.

3 participants