feat(utils): use multiple sources to download snark artifacts #273
Conversation
sripwoud
changed the title
sripwoud
changed the title
sripwoud
changed the title
import poseidon function, fetch artifacts and generate proof concurrently
|
|
||
| const getPackageVersions = async (proof: Proof) => | ||
| fetch(`${ARTIFACTS_BASE_URL}/${proof}-artifacts`) | ||
| fetch(`https://registry.npmjs.org/@zk-kit/${proof}-artifacts`) |
There was a problem hiding this comment.
spotted a mistake there, unrelated to this PR though
sripwoud
force-pushed
the
test/artifacts-timeout
branch
from
05babc6 to
71ba422
Compare
|
@cedoor After further testing, I can confirm that unpkg is throttling downloads. So deciding to combine multiple CDNs with a fetch retry will both make our tests faster and the artifacts fetching more reliable. I would wait for #275 to merge first before continuing there, as both our PRs touch the same functions though. |
|
|
||
| const ARTIFACTS_BASE_URL = "https://unpkg.com/@zk-kit" | ||
| const getBaseUrls = (proof: Proof, version: Version) => [ |
There was a problem hiding this comment.
my initial idea was to shuffle this randomly, but as privacy-scaling-explorations/snark-artifacts#23 told us how to rank them by download speed, we should follow that order
|
Will reopen in here privacy-scaling-explorations/snark-artifacts#65 |
wip
closes privacy-scaling-explorations/snark-artifacts#65