Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Kokkos 4.4.1, Parth vov-fix #124

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Bump Kokkos 4.4.1, Parth vov-fix #124

merged 5 commits into from
Nov 11, 2024

Conversation

pgrete
Copy link
Contributor

@pgrete pgrete commented Nov 9, 2024

Infrastructure-related changes:

  • Bumps Kokkos to 4.4.1 (to include SequentialHostInit for automatic deallocation of view of views)
  • Bumps Parthenon to include the view of views with SequentialHostInit
  • Bumps in Parthenon also now contain an updated path to enroll (custom) boundary conditions (via named strings, see cloud pgen)

AthenaPK-related changes:

  • Move the calculation of dt_diff to a single place (rather than in two different places depending on whether unsplit or rkl2 integration is used)
  • dt_hyp and dt_diff are now being read from restart files (as both values are now computed at the end of the loop, the contents are relevant for determining the substages in the RKL2 integrator and thus need to be known on restart).
  • Therefore, the dt plotted on the command line when using RKL2 integrator is now the correct one (previously it was overridden by the RKL2 integrator when limiting was in place only after the value was shown).

@pgrete pgrete changed the title WIP: Bump Kokkos 4.4.1, Parth vov-fix Bump Kokkos 4.4.1, Parth vov-fix Nov 10, 2024
@pgrete pgrete requested a review from BenWibking November 10, 2024 16:49
Copy link
Contributor

@BenWibking BenWibking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Only comment is that is might be slightly clearer to name dt_diff instead dt_parabolic or similar for consistency with dt_hyp (assuming hyp is for hyperbolic).

@BenWibking BenWibking merged commit 8ec1b55 into main Nov 11, 2024
4 checks passed
@pgrete pgrete deleted the pgrete/parth-vov-fix branch November 29, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants