Fix various dt_diff
issues recently introduced and bump Parthenon (for dn
outputs)
#129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several subtle issues introduced in #124 that are now fixed:
dt_diff
was reset prior to the STS tasks being added at the end of the driver (resulting in incorrect values ofdt_diff
for those tasks.To fix this the task resetting
dt_diff
is now called in a region followingAddSTSTasks
dt_diff
was used inAddSTSTasks
in the code that adds tasks themselves (and not within a task).Therefore, the tasks syncing/reducing
dt_diff
were not executed yet resulting in each rank using it's rank localdt_diff
.To fix this, the reduction "tasks" are now not tasks anymore but the reduction is called as
PreStepUserMeshWork
guaranteeing all info in sync before the task list is being constructed (and any tasks is executed).dt_diff
anddt_hyp
got theMutability::Restart
flag in Bump Kokkos 4.4.1, Parth vov-fix #124 causing issues when restarting an older sim that did not write these Params yet.Reading those is actually unnecessary with the move to reducing everything in
PreStepUserMeshWork
, so the Params are now justMutable
again and are not being read from the restart file.Finally, I updated the Parthenon submodule to include the now merged Kokkos 4.4.1 view of view fix and also the approved changes for
dn
based outputs.