feat: add SealedBlock in reth-primitives-traits #13735
Open
+3,004
−2,628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck-in-reth-primitives-traits
mattsse
commented
Jan 11, 2025
Comment on lines
+804
to
806
| pub block: Arc<SealedBlock<N::Block>>, | ||
| /// Block's senders. | ||
| pub senders: Arc<Vec<Address>>, |
There was a problem hiding this comment.
this can be simplified in a next step
mattsse
force-pushed
the
matt/introduce-sealed-block-in-reth-primitives-traits
branch
from
216ac40 to
2fe6d51
Compare
This was referenced Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13626
closes #13747
This unifies
BlockWithSendersandSealedBlockWithSendersintoRecoveredBlockadds various constructors and conversion between
SealedBlock <-> RecoveredBlockChanges overview
BlockWithSendersandSealedBlockWithSendersintoRecoveredBlockSealedBlockgeneric overB: Block, but keep the header,body fieldsSealedHeaderI've kept the aliases but these are now marked as deprecated