Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move evm code into independent crate #13694

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

move evm code into independent crate #13694

wants to merge 2 commits into from

Conversation

Pana
Copy link
Contributor

@Pana Pana commented Jan 7, 2025

No description provided.

@Pana Pana force-pushed the evmCodeStructure branch from d43de53 to 5e494f7 Compare January 7, 2025 05:00
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 7, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #13694 will not alter performance

Comparing Pana:evmCodeStructure (b1ab219) with main (383eb23)

Summary

✅ 77 untouched benchmarks

@Pana Pana closed this Jan 7, 2025
@Pana Pana reopened this Jan 7, 2025
@Pana
Copy link
Contributor Author

Pana commented Jan 11, 2025

Hey @mattsse can you check this pr

mattsse
mattsse approved these changes Jan 11, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,
I'm holding off on this because we have a big pr that would conflict here #13735

@mattsse mattsse added the S-blocked This cannot more forward until something else changes label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
S-blocked This cannot more forward until something else changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pana @mattsse