Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename crate reth-evm-ethereum to reth-ethereum-evm to keep consisten… #13695

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

rename crate reth-evm-ethereum to reth-ethereum-evm to keep consisten… #13695

wants to merge 3 commits into from
+73 −71

Conversation

Pana
Copy link
Contributor

@Pana Pana commented Jan 7, 2025

…t with reth-optimism-evm

@Pana Pana force-pushed the evmCodeStructure2 branch from 9ea1fc2 to 984a89d Compare January 7, 2025 05:01
@Pana
Copy link
Contributor Author

Pana commented Jan 11, 2025

Hey @mattsse can you check this pr

mattsse
mattsse approved these changes Jan 11, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also makes sense, also blocking this until #13735

@mattsse mattsse added the S-blocked This cannot more forward until something else changes label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@rakita rakita Awaiting requested review from rakita

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
S-blocked This cannot more forward until something else changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pana @mattsse