Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add SealedBlock::clone_sealed_header #13739

Merged
merged 1 commit into from
Jan 8, 2025
Merged

feat: add SealedBlock::clone_sealed_header #13739

merged 1 commit into from
Jan 8, 2025

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jan 8, 2025

prep for #13735

with #13735 fn sealed_header will be slightly problematic, luckily we can mostly call this to obtain a clone

@mattsse mattsse added the A-sdk Related to reth's use as a library label Jan 8, 2025
Rjected
Rjected approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, hopefully the next step is not too bad

@mattsse mattsse added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit 28d5231 Jan 8, 2025
42 of 43 checks passed
@mattsse mattsse deleted the matt/add-clone-sealed-header branch January 8, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @Rjected