feat: add Test traits for Header and Block #13741
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #13626
why we need these
currently the
SealedBlock
has some weird deref_mutreth/crates/primitives/src/block.rs
Lines 169 to 170 in f7ea2f4
that deref_muts to these testing helpers:
reth/crates/primitives-traits/src/header/sealed.rs
Lines 140 to 141 in f7ea2f4
with #13735 we won't have access to this easily because we don't have
SealedHeader
, so we could either do it via these traits or we duplicate all these setters forSealedBlock<alloy::Block>
imo these traits are easier to manage