Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Test traits for Header and Block #13741

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jan 8, 2025

towards #13626

why we need these

currently the SealedBlock has some weird deref_mut

#[deref_mut]
header: SealedHeader<H>,

that deref_muts to these testing helpers:

#[cfg(any(test, feature = "test-utils"))]
impl SealedHeader {

with #13735 we won't have access to this easily because we don't have SealedHeader, so we could either do it via these traits or we duplicate all these setters for SealedBlock<alloy::Block>

imo these traits are easier to manage

@mattsse mattsse added the A-sdk Related to reth's use as a library label Jan 8, 2025
@mattsse mattsse enabled auto-merge January 8, 2025 22:00
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should work for test utils

@mattsse mattsse added this pull request to the merge queue Jan 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2025
@Rjected Rjected added this pull request to the merge queue Jan 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2025
@mattsse mattsse merged commit 99932e4 into main Jan 9, 2025
43 checks passed
@mattsse mattsse deleted the matt/add-test-helper-traits branch January 9, 2025 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants