Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide empty asset offsets without codegen #3905

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jan 9, 2024

Description

This removes the necessity to generate the empty asset file in the Makefile. Switch between the empty and generated files at compile time via the noembedbins go build tag.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 added the chore label Jan 9, 2024
@twz123 twz123 force-pushed the noembedbins branch 7 times, most recently from 6a129e6 to fb6802f Compare January 9, 2024 16:48
@twz123 twz123 marked this pull request as ready for review January 10, 2024 08:15
@twz123 twz123 requested a review from a team as a code owner January 10, 2024 08:15
This removes the necessity to generate the empty asset file in the
Makefile. Switch between the empty and generated files at compile time
via the noembedbins go build tag.

Signed-off-by: Tom Wieczorek <[email protected]>
Copy link
Contributor

@juanluisvaladas juanluisvaladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I can run unit tests on macos and it passed the test suite so it has to be OK.

@twz123 twz123 merged commit 7ba8687 into k0sproject:main Jan 16, 2024
72 checks passed
@twz123 twz123 deleted the noembedbins branch January 16, 2024 10:54
@twz123 twz123 mentioned this pull request Apr 12, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants