[Backport release-1.29] Remove binary before building it #4309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Go compiler doesn't touch the binary if it doesn't detect any code changes. (Presumably by checking the BuildID of the old and the new binary?) However, the Makefile relied on a regeneration of the binary in any case, so that it can reappend the bindata file agan. Mitigate this by deleting the binary before the build. That way, the Go compiler doesn't have a choice. Fixes: 08df7f5 ("Provide empty asset offsets without codegen") Signed-off-by: Tom Wieczorek <[email protected]> (cherry picked from commit ad98aac)
16 tasks
twz123
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated backport to
release-1.29, triggered by a label in #4294.See #3905.