Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove binary before building it #4294

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Remove binary before building it #4294

merged 1 commit into from
Apr 17, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Apr 12, 2024

Description

The Go compiler doesn't touch the binary if it doesn't detect any code changes. (Presumably by checking the BuildID of the old and the new binary?) However, the Makefile relied on a regeneration of the binary in any case, so that it can reappend the bindata file agan. Mitigate this by deleting the binary before the build. That way, the Go compiler doesn't have a choice.

Fixes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 added bug Something isn't working backport/release-1.29 PR that needs to be backported/cherrypicked to the release-1.29 branch labels Apr 12, 2024
@twz123 twz123 marked this pull request as ready for review April 12, 2024 13:34
@twz123 twz123 requested a review from a team as a code owner April 12, 2024 13:34
@twz123 twz123 enabled auto-merge April 12, 2024 15:51
@twz123 twz123 added this to the 1.30 milestone Apr 16, 2024
ncopa
ncopa reviewed Apr 17, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@twz123
Remove binary before building it
ad98aac 
The Go compiler doesn't touch the binary if it doesn't detect any code
changes. (Presumably by checking the BuildID of the old and the new
binary?) However, the Makefile relied on a regeneration of the binary
in any case, so that it can reappend the bindata file agan. Mitigate
this by deleting the binary before the build. That way, the Go compiler
doesn't have a choice.

Fixes: 08df7f5 ("Provide empty asset offsets without codegen")
Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 merged commit 8aeb035 into k0sproject:main Apr 17, 2024
75 checks passed
@twz123 twz123 deleted the rm-binary-before-build branch April 17, 2024 11:50
@k0s-bot
Copy link

k0s-bot commented Apr 17, 2024

Successfully created backport PR for release-1.29:

@k0s-bot k0s-bot mentioned this pull request Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncopa ncopa ncopa approved these changes

@juanluisvaladas juanluisvaladas Awaiting requested review from juanluisvaladas juanluisvaladas is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
backport/release-1.29 PR that needs to be backported/cherrypicked to the release-1.29 branch bug Something isn't working
Projects
None yet
Milestone
1.30
Development

Successfully merging this pull request may close these issues.
3 participants
@twz123 @k0s-bot @ncopa