Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wording in LookAtModifier3D docs #99533

Merged

Conversation

crei0
Copy link
Contributor

@crei0 crei0 commented Nov 22, 2024

Fixed some typos and wording in documentation

@crei0 crei0 requested a review from a team as a code owner November 22, 2024 10:58
doc/classes/LookAtModifier3D.xml Outdated Show resolved Hide resolved
@AThousandShips AThousandShips changed the title Fixed 2 typos in documentation Fix typo in LookAtModifier3D docs Nov 22, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Nov 22, 2024
@AThousandShips AThousandShips requested a review from a team November 22, 2024 11:00
@Mickeon Mickeon removed the request for review from a team November 22, 2024 11:09
@akien-mga
Copy link
Member

Looks good! Before merging the commits need to be squashed to match our PR workflow (see that page for instructions).

As it's your first contribution, let us know if this seems a bit daunting, we're also happy to do it for you to ease the process.

@crei0 crei0 force-pushed the look_at_modifier3d_documentation_data_typos branch from 77d41a9 to 95c04d6 Compare November 22, 2024 11:42
@crei0
Copy link
Contributor Author

crei0 commented Nov 22, 2024

@akien-mga , I've squashed the commits

@AThousandShips AThousandShips changed the title Fix typo in LookAtModifier3D docs Fix wording in LookAtModifier3D docs Nov 22, 2024
@AThousandShips
Copy link
Member

Please update your commit message to be more descriptive, the title of the PR would be appropriate

@crei0 crei0 force-pushed the look_at_modifier3d_documentation_data_typos branch from 95c04d6 to e1fa489 Compare November 22, 2024 12:16
@crei0
Copy link
Contributor Author

crei0 commented Nov 22, 2024

@AThousandShips done, thank you

Copy link
Member

@TokageItLab TokageItLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the following up!

@Repiteo Repiteo merged commit a0211b0 into godotengine:master Nov 22, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 22, 2024

Thanks! Congratulations on your first merged contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LookAtModifier3D documentation data has typos
7 participants