[Cases] Fix case view flaky tests #160412

cnasikas · 2023-06-23T13:44:24Z

Summary

This PR fixes flaky tests in x-pack/plugins/cases/public/components/case_view/case_view_page.test.tsx. Some of them were converted to an e2e test as they were too slow to be on a unit test.

Successful runs:

a4ed839 (50 times)
82ccceb (45 times)
43c47e6 (20 times)

Fixes: #149775, #149776, #149777, #149778, #149779, #149780, #149781, #149782, #153335, #153336, #149773, #149774, #149772, #149771, #149770, #149769, #151845, #153336, #153335

Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2500

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2023-06-27T06:02:27Z

Pinging @elastic/response-ops (Team:ResponseOps)

elasticmachine · 2023-06-27T06:02:28Z

Pinging @elastic/response-ops-cases (Feature:Cases)

cnasikas · 2023-06-27T06:04:28Z

x-pack/plugins/cases/public/components/case_view/case_view_page.test.tsx

-    expect(result.getByTestId('case-view-status-dropdown')).toHaveTextContent('Closed');
-  });
-
-  it('should update status', async () => {


It was flaky. We have an e2e for that.

cnasikas · 2023-06-27T06:04:34Z

x-pack/plugins/cases/public/components/case_view/case_view_page.test.tsx

-    });
-  });
-
-  it('should update title', async () => {


It was flaky. We have an e2e for that.

cnasikas · 2023-06-27T06:05:58Z

x-pack/plugins/cases/public/components/case_view/case_view_page.test.tsx


-  it('should update connector', async () => {


It was flaky. We already test this scenario in the x-pack/plugins/cases/public/components/edit_connector/connectors_form.test.tsx file.

cnasikas · 2023-06-27T06:06:55Z

x-pack/plugins/cases/public/components/case_view/case_view_page.test.tsx

-        });
-      });
-
-      it.skip('it should persist the draft of new comment while description is updated', async () => {


Too slow. Moved it as an e2e (skipped).

cnasikas · 2023-06-27T06:07:53Z

x-pack/plugins/cases/public/components/case_view/case_view_page.test.tsx

-    });
-
-    describe('breadcrumbs', () => {
-      it('should set the cases title', () => {


It was flaky. We have an e2e for that.

js-jankisalvi

Changes looks good, thanks for doing this!! 👍

js-jankisalvi · 2023-06-27T09:04:01Z

x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts

+       * where this test randomly reproduces thus making the test flaky.
+       * Skipping for now until we fix it.
+       */
+      it.skip('should persist the draft of new comment while description is updated', async () => {


I will fix it in a separate PR, there is already an issue for it. #151845

jonathan-buttner · 2023-06-27T12:52:57Z

x-pack/plugins/cases/public/components/case_view/case_view_page.test.tsx

-      expect(result.container.querySelector('.euiCallOut--danger')).not.toBeInTheDocument();
+      expect(await screen.findByTestId('edit-connectors')).toBeInTheDocument();
+      expect(
+        screen.queryByTestId('case-callout-a25a5b368b6409b179ef4b6c5168244f')


Does the test id stay the same across test runs?

I discovered that yes! The footprint of this callout is the same. This is the expected behavior.

jonathan-buttner · 2023-06-27T12:55:16Z

x-pack/plugins/cases/public/components/edit_connector/index.tsx

@@ -90,7 +90,7 @@ export const EditConnector = React.memo(
      !needsToBePushed;

    return (
-      <EuiFlexItem grow={false}>
+      <EuiFlexItem grow={false} data-test-subj="sidebar-connectors">


nit: maybe prefix these with cases-

jonathan-buttner · 2023-06-27T12:59:04Z

x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts

+         * fast to the cases table and the comment is not
+         * persisted
+         */
+        await setTimeoutAsync(2000);


kibana-ci · 2023-06-27T13:10:45Z

💚 Build Succeeded

Buildkite Build
Commit: 82faa0e

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cases`	420.8KB	420.9KB	+116.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`cases`	58	59	+1
`enterpriseSearch`	14	16	+2
`securitySolution`	416	420	+4
total			+7

Total ESLint disabled count

id	before	after	diff
`cases`	75	76	+1
`enterpriseSearch`	15	17	+2
`securitySolution`	497	501	+4
total			+7

History

💔 Build #138388 failed 4007407
💔 Build #138346 failed abaead4
💔 Build #138342 failed e344caa75b60be455820e9b0144a702099859266
💚 Build #138326 succeeded 0d52d79
💚 Build #138295 succeeded 88b6cb9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

## Summary This PR fixes flaky tests in `x-pack/plugins/cases/public/components/case_view/case_view_page.test.tsx`. Some of them were converted to an e2e test as they were too slow to be on a unit test. Successful runs: - elastic@a4ed839 (50 times) - elastic@82ccceb (45 times) - elastic@43c47e6 (20 times) Fixes: elastic#149775, elastic#149776, elastic#149777, elastic#149778, elastic#149779, elastic#149780, elastic#149781, elastic#149782, elastic#153335, elastic#153336, elastic#149773, elastic#149774, elastic#149772, elastic#149771, elastic#149770, elastic#149769, elastic#151845, elastic#153336, elastic#153335 Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2500 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit c0047a1)

kibanamachine · 2023-06-27T14:03:41Z

💚 All backports created successfully

Status	Branch	Result
✅	8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

cnasikas added 2 commits June 23, 2023 16:42

Fix flaky tests

36273eb

Run test 50 times

5eea7cf

cnasikas added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.9.0 v8.10.0 labels Jun 23, 2023

cnasikas self-assigned this Jun 23, 2023

cnasikas added 7 commits June 24, 2023 09:19

Run 40 times

995d709

Small fixes

9789a15

Move flaky test to e2e

48e8857

Fix callouts

0d5dce4

Move breadcrumb to e2e

9f42d90

Run 45 times

13c3f69

Fix tabs

a488c7e

cnasikas added 5 commits June 25, 2023 11:28

Merge branch 'main' into fix_case_view_flaky_tests

cae1640

Fix syntax error

65b6691

Move test as e2e

e90e3b7

Mock useCasesFeatures

14576db

Fix tests

88a3211

cnasikas requested a review from a team as a code owner June 27, 2023 06:02

cnasikas commented Jun 27, 2023

View reviewed changes

adcoelho approved these changes Jun 27, 2023

View reviewed changes

cnasikas force-pushed the fix_case_view_flaky_tests branch from f3efff4 to e344caa Compare June 27, 2023 07:46

Fix flaky

abaead4

cnasikas force-pushed the fix_case_view_flaky_tests branch from e344caa to abaead4 Compare June 27, 2023 07:51

js-jankisalvi approved these changes Jun 27, 2023

View reviewed changes

cnasikas added 2 commits June 27, 2023 12:51

Fix test

4007407

Delete cases on each restart and wait for comment to be persisted

82faa0e

jonathan-buttner reviewed Jun 27, 2023

View reviewed changes

cnasikas merged commit c0047a1 into elastic:main Jun 27, 2023

cnasikas deleted the fix_case_view_flaky_tests branch June 27, 2023 13:57

cnasikas mentioned this pull request Jun 27, 2023

Failing test: Jest Tests.x-pack/plugins/cases/public/components/case_view/components - Case View Page activity tab Case users User actions renders the user action users correctly #151981

Closed

kibanamachine mentioned this pull request Jun 27, 2023

[8.9] [Cases] Fix case view flaky tests (#160412) #160629

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cases] Fix case view flaky tests #160412

[Cases] Fix case view flaky tests #160412

cnasikas commented Jun 23, 2023 •

edited by kibanamachine

Loading

elasticmachine commented Jun 27, 2023

elasticmachine commented Jun 27, 2023

cnasikas Jun 27, 2023 •

edited

Loading

cnasikas Jun 27, 2023 •

edited

Loading

cnasikas Jun 27, 2023

cnasikas Jun 27, 2023

cnasikas Jun 27, 2023

js-jankisalvi left a comment

js-jankisalvi Jun 27, 2023

jonathan-buttner Jun 27, 2023

cnasikas Jun 27, 2023

jonathan-buttner Jun 27, 2023

jonathan-buttner Jun 27, 2023

kibana-ci commented Jun 27, 2023

ESLint disabled line counts

Total ESLint disabled count

kibanamachine commented Jun 27, 2023

[Cases] Fix case view flaky tests #160412

[Cases] Fix case view flaky tests #160412

Conversation

cnasikas commented Jun 23, 2023 • edited by kibanamachine Loading

Summary

Checklist

For maintainers

elasticmachine commented Jun 27, 2023

elasticmachine commented Jun 27, 2023

cnasikas Jun 27, 2023 • edited Loading

Choose a reason for hiding this comment

cnasikas Jun 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

js-jankisalvi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kibana-ci commented Jun 27, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

ESLint disabled line counts

Total ESLint disabled count

History

kibanamachine commented Jun 27, 2023

💚 All backports created successfully

Questions ?

cnasikas commented Jun 23, 2023 •

edited by kibanamachine

Loading

cnasikas Jun 27, 2023 •

edited

Loading

cnasikas Jun 27, 2023 •

edited

Loading