Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases] Fix case view flaky tests #160412

Merged
merged 24 commits into from
Jun 27, 2023
Merged

[Cases] Fix case view flaky tests #160412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
36273eb
Fix flaky tests
cnasikas Jun 23, 2023
5eea7cf
Run test 50 times
cnasikas Jun 23, 2023
995d709
Run 40 times
cnasikas Jun 24, 2023
9789a15
Small fixes
cnasikas Jun 24, 2023
48e8857
Move flaky test to e2e
cnasikas Jun 24, 2023
0d5dce4
Fix callouts
cnasikas Jun 24, 2023
9f42d90
Move breadcrumb to e2e
cnasikas Jun 24, 2023
13c3f69
Run 45 times
cnasikas Jun 24, 2023
a488c7e
Fix tabs
cnasikas Jun 25, 2023
cae1640
Merge branch 'main' into fix_case_view_flaky_tests
cnasikas Jun 25, 2023
65b6691
Fix syntax error
cnasikas Jun 25, 2023
e90e3b7
Move test as e2e
cnasikas Jun 26, 2023
14576db
Mock useCasesFeatures
cnasikas Jun 26, 2023
88a3211
Fix tests
cnasikas Jun 26, 2023
687561c
Remove connector's test
cnasikas Jun 26, 2023
a4ed839
Remove tests we already test as e2e
cnasikas Jun 26, 2023
dc78c1f
Run 45 times more
cnasikas Jun 26, 2023
82ccceb
Merge branch 'main' into fix_case_view_flaky_tests
cnasikas Jun 26, 2023
43c47e6
Run 20 more times
cnasikas Jun 26, 2023
88b6cb9
Run 25 more times
cnasikas Jun 26, 2023
0d52d79
Remove multiple runners
cnasikas Jun 27, 2023
abaead4
Fix flaky
cnasikas Jun 27, 2023
4007407
Fix test
cnasikas Jun 27, 2023
82faa0e
Delete cases on each restart and wait for comment to be persisted
cnasikas Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...ic/common/lib/kibana/kibana_react.mock.ts → ...c/common/lib/kibana/kibana_react.mock.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ interface StartServiceArgs {

export const createStartServicesMock = ({ license }: StartServiceArgs = {}): StartServices => {
const licensingPluginMock = licensingMock.createStart();
const triggersActionsUi = triggersActionsUiMock.createStart();

const services = {
...coreMock.createStart(),
Expand All @@ -39,7 +40,11 @@ export const createStartServicesMock = ({ license }: StartServiceArgs = {}): Sta
navigateToPrefilledEditor: jest.fn(),
},
security: securityMock.createStart(),
triggersActionsUi: triggersActionsUiMock.createStart(),
triggersActionsUi: {
actionTypeRegistry: triggersActionsUi.actionTypeRegistry,
alertsTableConfigurationRegistry: triggersActionsUi.alertsTableConfigurationRegistry,
getAlertsStateTable: jest.fn().mockReturnValue(<div data-test-subj="alerts-table" />),
Comment on lines +43 to +46
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The triggersActionsUiMock does not mock their components etc so it is not actually a mock. I mocked them here explicitly to make the tests faster and not load the whole alerts table.

},
spaces: spacesPluginMock.createStartContract(),
licensing:
license != null
Expand Down
Loading