Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Tests.x-pack/plugins/cases/public/components/case_view - CaseViewPage Tabs renders the activity tab when the query parameter tabId has activity #149776

Closed
kibanamachine opened this issue Jan 27, 2023 · 8 comments · Fixed by #160412 or #172940
Closed

Failing test: Jest Tests.x-pack/plugins/cases/public/components/case_view - CaseViewPage Tabs renders the activity tab when the query parameter tabId has activity #149776

kibanamachine opened this issue Jan 27, 2023 · 8 comments · Fixed by #160412 or #172940
Assignees
@cnasikas
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 27, 2023 •
edited
Loading

A test failed on a tracked branch

TestingLibraryElementError: Unable to find an element by: [data-test-subj="case-view-tab-content-activity"]

Ignored nodes: comments, script, style
<body>
  <div />
</body>
    at Object.getElementError (/var/lib/buildkite-agent/builds/kb-n2-4-spot-3f2434e6d3ddd216/elastic/kibana-on-merge/kibana/node_modules/@testing-library/dom/dist/config.js:40:19)
    at /var/lib/buildkite-agent/builds/kb-n2-4-spot-3f2434e6d3ddd216/elastic/kibana-on-merge/kibana/node_modules/@testing-library/dom/dist/query-helpers.js:90:38
    at /var/lib/buildkite-agent/builds/kb-n2-4-spot-3f2434e6d3ddd216/elastic/kibana-on-merge/kibana/node_modules/@testing-library/dom/dist/query-helpers.js:62:17
    at /var/lib/buildkite-agent/builds/kb-n2-4-spot-3f2434e6d3ddd216/elastic/kibana-on-merge/kibana/node_modules/@testing-library/dom/dist/query-helpers.js:111:19
    at getByTestId (/var/lib/buildkite-agent/builds/kb-n2-4-spot-3f2434e6d3ddd216/elastic/kibana-on-merge/kibana/x-pack/plugins/cases/public/components/case_view/case_view_page.test.tsx:500:23)
    at batchedUpdates$1 (/var/lib/buildkite-agent/builds/kb-n2-4-spot-3f2434e6d3ddd216/elastic/kibana-on-merge/kibana/node_modules/react-dom/cjs/react-dom.development.js:22380:12)
    at act (/var/lib/buildkite-agent/builds/kb-n2-4-spot-3f2434e6d3ddd216/elastic/kibana-on-merge/kibana/node_modules/react-dom/cjs/react-dom-test-utils.development.js:1042:14)
    at Object.<anonymous> (/var/lib/buildkite-agent/builds/kb-n2-4-spot-3f2434e6d3ddd216/elastic/kibana-on-merge/kibana/x-pack/plugins/cases/public/components/case_view/case_view_page.test.tsx:499:16)
    at Promise.then.completed (/var/lib/buildkite-agent/builds/kb-n2-4-spot-3f2434e6d3ddd216/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/utils.js:289:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/var/lib/buildkite-agent/builds/kb-n2-4-spot-3f2434e6d3ddd216/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/utils.js:222:10)
    at _callCircusTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-3f2434e6d3ddd216/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:248:40)
    at runNextTicks (node:internal/process/task_queues:61:5)
    at processTimers (node:internal/timers:499:9)
    at _runTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-3f2434e6d3ddd216/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:184:3)
    at _runTestsForDescribeBlock (/var/lib/buildkite-agent/builds/kb-n2-4-spot-3f2434e6d3ddd216/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:86:9)
    at _runTestsForDescribeBlock (/var/lib/buildkite-agent/builds/kb-n2-4-spot-3f2434e6d3ddd216/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:81:9)
    at _runTestsForDescribeBlock (/var/lib/buildkite-agent/builds/kb-n2-4-spot-3f2434e6d3ddd216/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:81:9)
    at run (/var/lib/buildkite-agent/builds/kb-n2-4-spot-3f2434e6d3ddd216/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:26:3)
    at runAndTransformResultsToJestFormat (/var/lib/buildkite-agent/builds/kb-n2-4-spot-3f2434e6d3ddd216/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:120:21)
    at jestAdapter (/var/lib/buildkite-agent/builds/kb-n2-4-spot-3f2434e6d3ddd216/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/var/lib/buildkite-agent/builds/kb-n2-4-spot-3f2434e6d3ddd216/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-3f2434e6d3ddd216/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:444:34)

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jan 27, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 27, 2023
@kibanamachine kibanamachine added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Jan 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 27, 2023
@cnasikas cnasikas added the Feature:Cases Cases feature label Jan 30, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@jonathan-buttner jonathan-buttner linked a pull request Feb 10, 2023 that will close this issue
[Cases] Improve slow CaseViewPage jest tests #150952
Closed
@jonathan-buttner jonathan-buttner mentioned this issue Feb 10, 2023
Closed
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue Mar 21, 2023
@mistic
skip flaky suite (#149775,#149776,#149777,#149778,#149779,#149780,#14…
f4d8b10 
…9781,#149782,#153335,#153336)
@mistic
Copy link
Member

mistic commented Mar 21, 2023

Skipped.

main: f4d8b10

@jonathan-buttner jonathan-buttner removed their assignment Apr 24, 2023
@cnasikas cnasikas mentioned this issue Jun 25, 2023
Merged
2 tasks
@cnasikas cnasikas linked a pull request Jun 25, 2023 that will close this issue
[Cases] Fix case view flaky tests #160412
Merged
2 tasks
cnasikas added a commit that referenced this issue Jun 27, 2023
@cnasikas
[Cases] Fix case view flaky tests (#160412)
c0047a1 
## Summary

This PR fixes flaky tests in
`x-pack/plugins/cases/public/components/case_view/case_view_page.test.tsx`.
Some of them were converted to an e2e test as they were too slow to be
on a unit test.

Successful runs: 

-
a4ed839
(50 times)
-
82ccceb
(45 times)
-
43c47e6
(20 times)

Fixes: #149775,
#149776,
#149777,
#149778,
#149779,
#149780,
#149781,
#149782,
#153335,
#153336,
#149773,
#149774,
#149772,
#149771,
#149770,
#149769,
#151845,
#153336,
#153335

Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2500

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jun 27, 2023
@cnasikas
[Cases] Fix case view flaky tests (elastic#160412)
e9e3403 
## Summary

This PR fixes flaky tests in
`x-pack/plugins/cases/public/components/case_view/case_view_page.test.tsx`.
Some of them were converted to an e2e test as they were too slow to be
on a unit test.

Successful runs:

-
elastic@a4ed839
(50 times)
-
elastic@82ccceb
(45 times)
-
elastic@43c47e6
(20 times)

Fixes: elastic#149775,
elastic#149776,
elastic#149777,
elastic#149778,
elastic#149779,
elastic#149780,
elastic#149781,
elastic#149782,
elastic#153335,
elastic#153336,
elastic#149773,
elastic#149774,
elastic#149772,
elastic#149771,
elastic#149770,
elastic#149769,
elastic#151845,
elastic#153336,
elastic#153335

Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2500

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit c0047a1)
@kibanamachine kibanamachine reopened this Nov 6, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.11

@cnasikas cnasikas self-assigned this Dec 5, 2023
@cnasikas cnasikas mentioned this issue Dec 8, 2023
Merged
2 tasks
@cnasikas cnasikas linked a pull request Dec 8, 2023 that will close this issue
[Cases] Fix flaky tests in the CaseViewPage component #172940
Merged
2 tasks
cnasikas added a commit that referenced this issue Jan 15, 2024
@cnasikas @kibanamachine
[Cases] Fix flaky tests in the CaseViewPage component (#172940)
5b8c212 
## Summary

Tests:

- `renders tabs correctly`: Moved to functional testing
- `renders the activity tab by default`: Removed. It is being tested in
functional testing
- `renders the activity tab when the query parameter tabId has
activity`: Moved to functional testing
- `renders the activity tab when the query parameter tabId has an
unknown value`: Moved to functional testing
- `navigates to the activity tab when the activity tab is clicked`:
Moved to functional testing
- `should show closed indicators in header when case is closed`: Moved
to
`x-pack/plugins/cases/public/components/case_action_bar/index.test.tsx`
- `should push updates on button click`: Moved to
`x-pack/plugins/cases/public/components/edit_connector/index.test.tsx`
- `should disable the push button when connector is invalid`: Moved to
`x-pack/plugins/cases/public/components/edit_connector/index.test.tsx`
- `should show the rule name`: Already tested in
`x-pack/plugins/cases/public/components/user_actions/comment/alert_event.test.tsx`
- `should show the correct connector name on the push button`: Moved to
`x-pack/plugins/cases/public/components/edit_connector/index.test.tsx`
- `Callouts`: Already tested in
`x-pack/plugins/cases/public/components/use_push_to_service/index.test.tsx`
- `should display the alerts tab when the feature is enabled`: Moved to
`x-pack/plugins/cases/public/components/case_view/case_view_tabs.test.tsx`
- `should not display the alerts tab when the feature is disabled`:
Moved to
`x-pack/plugins/cases/public/components/case_view/case_view_tabs.test.tsx`
- `should not show the experimental badge on the alerts table`: Moved to
`x-pack/plugins/cases/public/components/case_view/case_view_tabs.test.tsx`
- `should show the experimental badge on the alerts table`: Moved to
`x-pack/plugins/cases/public/components/case_view/case_view_tabs.test.tsx`
- `renders the alerts tab when the query parameter tabId has alerts`:
Unskip functional test
- `navigates to the alerts tab when the alerts tab is clicked`: Removed.
It is being tested in functional testing
- `shows the connectors in the sidebar`: Removed. It is being tested in
functional testing
- `shows the case action bar`: Removed. It is being tested in functional
testing
- `should show loading content when loading user actions stats`:
Removed. Already tested in
`x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx`
- `should call show alert details with expected arguments`: Removed.
Already tested in
`x-pack/plugins/cases/public/components/user_actions/comment/comment.test.tsx`
- `should show the case tabs`: Moved to functional testing
- `should display description when case is loading`: Moved to
`x-pack/plugins/cases/public/components/description/index.test.tsx`
- `renders the description correctly`: Removed. Already tested in
`x-pack/plugins/cases/public/components/description/index.test.tsx`
- `should update settings`: Removed. Already tested in
`x-pack/plugins/cases/public/components/case_action_bar/index.test.tsx`



Fixes: #149778,
#149777,
#149776,
#170532,
#171718,
#149771,
#173136

Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4862

Successful builds:
https://buildkite.com/elastic/kibana-pull-request/builds?branch=cnasikas%3Afix_149777

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cnasikas cnasikas

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
5 participants
@mistic @cnasikas @elasticmachine @kibanamachine @jonathan-buttner