Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: Jest Tests.x-pack/plugins/cases/public/components/case_view/components - Case View Page activity tab Case users User actions renders the user action users correctly #151981

Closed
kibanamachine opened this issue Feb 23, 2023 · 9 comments · Fixed by #160639 or #170324
Assignees
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 23, 2023

A test failed on a tracked branch

TestingLibraryElementError: Unable to find an element by: [data-test-subj="user-actions"]

Ignored nodes: comments, script, style
<body>
  <div />
</body>
    at Object.getElementError (/var/lib/buildkite-agent/builds/kb-n2-4-spot-0280de6a7188b6cd/elastic/kibana-on-merge/kibana/node_modules/@testing-library/dom/dist/config.js:40:19)
    at /var/lib/buildkite-agent/builds/kb-n2-4-spot-0280de6a7188b6cd/elastic/kibana-on-merge/kibana/node_modules/@testing-library/dom/dist/query-helpers.js:90:38
    at /var/lib/buildkite-agent/builds/kb-n2-4-spot-0280de6a7188b6cd/elastic/kibana-on-merge/kibana/node_modules/@testing-library/dom/dist/query-helpers.js:62:17
    at /var/lib/buildkite-agent/builds/kb-n2-4-spot-0280de6a7188b6cd/elastic/kibana-on-merge/kibana/node_modules/@testing-library/dom/dist/query-helpers.js:111:19
    at Object.getByTestId (/var/lib/buildkite-agent/builds/kb-n2-4-spot-0280de6a7188b6cd/elastic/kibana-on-merge/kibana/x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx:580:43)
    at Promise.then.completed (/var/lib/buildkite-agent/builds/kb-n2-4-spot-0280de6a7188b6cd/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/utils.js:289:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/var/lib/buildkite-agent/builds/kb-n2-4-spot-0280de6a7188b6cd/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/utils.js:222:10)
    at _callCircusTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-0280de6a7188b6cd/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:248:40)
    at runNextTicks (node:internal/process/task_queues:61:5)
    at processTimers (node:internal/timers:499:9)
    at _runTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-0280de6a7188b6cd/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:184:3)
    at _runTestsForDescribeBlock (/var/lib/buildkite-agent/builds/kb-n2-4-spot-0280de6a7188b6cd/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:86:9)
    at _runTestsForDescribeBlock (/var/lib/buildkite-agent/builds/kb-n2-4-spot-0280de6a7188b6cd/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:81:9)
    at _runTestsForDescribeBlock (/var/lib/buildkite-agent/builds/kb-n2-4-spot-0280de6a7188b6cd/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:81:9)
    at _runTestsForDescribeBlock (/var/lib/buildkite-agent/builds/kb-n2-4-spot-0280de6a7188b6cd/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:81:9)
    at run (/var/lib/buildkite-agent/builds/kb-n2-4-spot-0280de6a7188b6cd/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/run.js:26:3)
    at runAndTransformResultsToJestFormat (/var/lib/buildkite-agent/builds/kb-n2-4-spot-0280de6a7188b6cd/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:120:21)
    at jestAdapter (/var/lib/buildkite-agent/builds/kb-n2-4-spot-0280de6a7188b6cd/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/var/lib/buildkite-agent/builds/kb-n2-4-spot-0280de6a7188b6cd/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-0280de6a7188b6cd/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:444:34)

First failure: CI Build - main

@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Feb 23, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 23, 2023
@kibanamachine kibanamachine added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Feb 23, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Feb 23, 2023
@cnasikas cnasikas added the Feature:Cases Cases feature label Feb 23, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

jbudz added a commit that referenced this issue Feb 27, 2023
@jbudz
Copy link
Member

jbudz commented Feb 27, 2023

Skipped

main: b868490

bmorelli25 pushed a commit to bmorelli25/kibana that referenced this issue Mar 10, 2023
@cnasikas cnasikas reopened this Jun 27, 2023
@cnasikas cnasikas linked a pull request Jun 29, 2023 that will close this issue
2 tasks
cnasikas added a commit that referenced this issue Jun 29, 2023
## Summary

Fixes flaky tests in
`x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx`

Successful runs:

-
a7a19c1
(40 times)
-
f5e0645
(45 times)
-
d9838cc
(40 times)

Fixes: #151981,
#151979,
#151980,
#152209,
#152207,
#152208,
#152203,
#152203,
#152201,
#152206,
#152202,
#152204,
#152200

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jun 29, 2023
## Summary

Fixes flaky tests in
`x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx`

Successful runs:

-
elastic@a7a19c1
(40 times)
-
elastic@f5e0645
(45 times)
-
elastic@d9838cc
(40 times)

Fixes: elastic#151981,
elastic#151979,
elastic#151980,
elastic#152209,
elastic#152207,
elastic#152208,
elastic#152203,
elastic#152203,
elastic#152201,
elastic#152206,
elastic#152202,
elastic#152204,
elastic#152200

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 6349724)
kibanamachine referenced this issue Jun 30, 2023
…0930)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[Cases] Test `case_view_activity.test.tsx` suite
(#160639)](#160639)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Christos
Nasikas","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-06-29T16:33:20Z","message":"[Cases]
Test `case_view_activity.test.tsx` suite (#160639)\n\n##
Summary\r\n\r\nFixes flaky tests
in\r\n`x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx`\r\n\r\nSuccessful
runs:\r\n\r\n-\r\nhttps://github.com//pull/160639/commits/a7a19c1a74df5ca9202dcb1516b9284d3faf2b2a\r\n(40
times)\r\n-\r\nhttps://github.com//pull/160639/commits/f5e0645ebd3f8bbfedab52bea02669d3e1fe9b06\r\n(45
times)\r\n-\r\nhttps://github.com//pull/160639/commits/d9838cc71ba130612b3e6610df453987d39bfe42\r\n(40
times)\r\n\r\nFixes:
https://github.com/elastic/kibana/issues/151981,\r\nhttps://github.com/elastic/kibana/issues/151979,\r\nhttps://github.com/elastic/kibana/issues/151980,\r\nhttps://github.com/elastic/kibana/issues/152209,\r\nhttps://github.com/elastic/kibana/issues/152207,\r\nhttps://github.com/elastic/kibana/issues/152208,\r\nhttps://github.com/elastic/kibana/issues/152203,\r\nhttps://github.com/elastic/kibana/issues/152203,\r\nhttps://github.com/elastic/kibana/issues/152201,\r\nhttps://github.com/elastic/kibana/issues/152206,\r\nhttps://github.com/elastic/kibana/issues/152202,https://github.com/elastic/kibana/issues/152205,\r\nhttps://github.com/elastic/kibana/issues/152204,\r\nhttps://github.com/elastic/kibana/issues/152200\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [x] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"6349724ff26d23fe927d8cb69fef642d76b396df","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Feature:Cases","v8.9.0","v8.10.0"],"number":160639,"url":"https://github.com/elastic/kibana/pull/160639","mergeCommit":{"message":"[Cases]
Test `case_view_activity.test.tsx` suite (#160639)\n\n##
Summary\r\n\r\nFixes flaky tests
in\r\n`x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx`\r\n\r\nSuccessful
runs:\r\n\r\n-\r\nhttps://github.com//pull/160639/commits/a7a19c1a74df5ca9202dcb1516b9284d3faf2b2a\r\n(40
times)\r\n-\r\nhttps://github.com//pull/160639/commits/f5e0645ebd3f8bbfedab52bea02669d3e1fe9b06\r\n(45
times)\r\n-\r\nhttps://github.com//pull/160639/commits/d9838cc71ba130612b3e6610df453987d39bfe42\r\n(40
times)\r\n\r\nFixes:
https://github.com/elastic/kibana/issues/151981,\r\nhttps://github.com/elastic/kibana/issues/151979,\r\nhttps://github.com/elastic/kibana/issues/151980,\r\nhttps://github.com/elastic/kibana/issues/152209,\r\nhttps://github.com/elastic/kibana/issues/152207,\r\nhttps://github.com/elastic/kibana/issues/152208,\r\nhttps://github.com/elastic/kibana/issues/152203,\r\nhttps://github.com/elastic/kibana/issues/152203,\r\nhttps://github.com/elastic/kibana/issues/152201,\r\nhttps://github.com/elastic/kibana/issues/152206,\r\nhttps://github.com/elastic/kibana/issues/152202,https://github.com/elastic/kibana/issues/152205,\r\nhttps://github.com/elastic/kibana/issues/152204,\r\nhttps://github.com/elastic/kibana/issues/152200\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [x] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"6349724ff26d23fe927d8cb69fef642d76b396df"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160639","number":160639,"mergeCommit":{"message":"[Cases]
Test `case_view_activity.test.tsx` suite (#160639)\n\n##
Summary\r\n\r\nFixes flaky tests
in\r\n`x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx`\r\n\r\nSuccessful
runs:\r\n\r\n-\r\nhttps://github.com//pull/160639/commits/a7a19c1a74df5ca9202dcb1516b9284d3faf2b2a\r\n(40
times)\r\n-\r\nhttps://github.com//pull/160639/commits/f5e0645ebd3f8bbfedab52bea02669d3e1fe9b06\r\n(45
times)\r\n-\r\nhttps://github.com//pull/160639/commits/d9838cc71ba130612b3e6610df453987d39bfe42\r\n(40
times)\r\n\r\nFixes:
https://github.com/elastic/kibana/issues/151981,\r\nhttps://github.com/elastic/kibana/issues/151979,\r\nhttps://github.com/elastic/kibana/issues/151980,\r\nhttps://github.com/elastic/kibana/issues/152209,\r\nhttps://github.com/elastic/kibana/issues/152207,\r\nhttps://github.com/elastic/kibana/issues/152208,\r\nhttps://github.com/elastic/kibana/issues/152203,\r\nhttps://github.com/elastic/kibana/issues/152203,\r\nhttps://github.com/elastic/kibana/issues/152201,\r\nhttps://github.com/elastic/kibana/issues/152206,\r\nhttps://github.com/elastic/kibana/issues/152202,https://github.com/elastic/kibana/issues/152205,\r\nhttps://github.com/elastic/kibana/issues/152204,\r\nhttps://github.com/elastic/kibana/issues/152200\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [x] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"6349724ff26d23fe927d8cb69fef642d76b396df"}}]}]
BACKPORT-->

Co-authored-by: Christos Nasikas <[email protected]>
@kibanamachine kibanamachine reopened this Jun 30, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@mistic
Copy link
Member

mistic commented Jul 4, 2023

Skipped.

main: 9de4cc5
8.9: 85a2e1b

jloleysens added a commit to jloleysens/kibana that referenced this issue Jul 5, 2023
* main: (354 commits)
  [Synthetics] Overview page fix last refresh value display (elastic#161086)
  [Synthetics] Remove TLS alert option for ICMP monitor (elastic#161173)
  fixing the path of manifets for hints autodiscover (elastic#161075)
  [Fleet] Fix permissions in integrations Assets page (elastic#161233)
  Update publicBaseUrl warning id (elastic#161204)
  [ML] Fix Anomaly Explorer URL for alerting context with non-default space  (elastic#160899)
  [Enterprise Search]Add 404 error handling for mappings and documents endpoints (elastic#161203)
  [Logs Shared] Move LogStream and LogView into new shared plugin (elastic#161151)
  [Security Solutions] Fix  CellActions component should hide ShowTopN action for nested fields (elastic#159645)
  [SecuritySolutions] Remove filter actions from Cases alerts table and fix show_top_n action (elastic#161150)
  [Infrastructure UI] Add strict payload validation to inventory_views endpoint (elastic#160852)
  [api-docs] 2023-07-05 Daily api_docs build (elastic#161225)
  Fix errors in custom metric payload in SLO dev docs (elastic#161141)
  [data views] Fix overwrite param for create (elastic#160953)
  [Synthetics] Perform params API HTTP migration (elastic#160575)
  [Cloud Security][FTR]Refactor API FTR to use .to.eql instead of .to.be  (elastic#160694)
  Have SLO routes return a 403 instead of a 400 when user has an insufficient license (elastic#161193)
  [Discover] Fix shared links flaky test (elastic#161172)
  [ftr] Improve FTR error handling for NoSuchSessionError (elastic#161025)
  skip flaky suite (elastic#151981)
  ...
jloleysens added a commit to jloleysens/kibana that referenced this issue Jul 5, 2023
* main: (354 commits)
  [Synthetics] Overview page fix last refresh value display (elastic#161086)
  [Synthetics] Remove TLS alert option for ICMP monitor (elastic#161173)
  fixing the path of manifets for hints autodiscover (elastic#161075)
  [Fleet] Fix permissions in integrations Assets page (elastic#161233)
  Update publicBaseUrl warning id (elastic#161204)
  [ML] Fix Anomaly Explorer URL for alerting context with non-default space  (elastic#160899)
  [Enterprise Search]Add 404 error handling for mappings and documents endpoints (elastic#161203)
  [Logs Shared] Move LogStream and LogView into new shared plugin (elastic#161151)
  [Security Solutions] Fix  CellActions component should hide ShowTopN action for nested fields (elastic#159645)
  [SecuritySolutions] Remove filter actions from Cases alerts table and fix show_top_n action (elastic#161150)
  [Infrastructure UI] Add strict payload validation to inventory_views endpoint (elastic#160852)
  [api-docs] 2023-07-05 Daily api_docs build (elastic#161225)
  Fix errors in custom metric payload in SLO dev docs (elastic#161141)
  [data views] Fix overwrite param for create (elastic#160953)
  [Synthetics] Perform params API HTTP migration (elastic#160575)
  [Cloud Security][FTR]Refactor API FTR to use .to.eql instead of .to.be  (elastic#160694)
  Have SLO routes return a 403 instead of a 400 when user has an insufficient license (elastic#161193)
  [Discover] Fix shared links flaky test (elastic#161172)
  [ftr] Improve FTR error handling for NoSuchSessionError (elastic#161025)
  skip flaky suite (elastic#151981)
  ...
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.9

@mistic mistic added the v8.9.1 label Jul 13, 2023
mistic added a commit that referenced this issue Jul 13, 2023
@js-jankisalvi js-jankisalvi self-assigned this Nov 1, 2023
js-jankisalvi added a commit that referenced this issue Nov 2, 2023
## Summary

I removed the description user actions tests from
`x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx`

There were a few things being tested:

| Old Test  | Where is it covered |
| ------------- | ------------- |
| should render the description correctly | added description
integration on case view activity page `should render the activity
content and main components` , text of the description is already
verified in
`x-pack/plugins/cases/public/components/user_actions/description.test.tsx`
|
| renders edit description user action correctly | Already testing
description create and update user actions in `renders user actions
correctly` in file
`x-pack/plugins/cases/public/components/user_actions/user_actions_list.test.tsx`
|


Fixes #151981

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 2, 2023
## Summary

I removed the description user actions tests from
`x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx`

There were a few things being tested:

| Old Test  | Where is it covered |
| ------------- | ------------- |
| should render the description correctly | added description
integration on case view activity page `should render the activity
content and main components` , text of the description is already
verified in
`x-pack/plugins/cases/public/components/user_actions/description.test.tsx`
|
| renders edit description user action correctly | Already testing
description create and update user actions in `renders user actions
correctly` in file
`x-pack/plugins/cases/public/components/user_actions/user_actions_list.test.tsx`
|

Fixes elastic#151981

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 1d337e3)
kibanamachine referenced this issue Nov 2, 2023
…0420)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Cases] fix description user actions flaky test
(#170324)](#170324)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Janki
Salvi","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-02T13:52:25Z","message":"[Cases]
fix description user actions flaky test (#170324)\n\n## Summary\r\n\r\nI
removed the description user actions tests
from\r\n`x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx`\r\n\r\nThere
were a few things being tested:\r\n\r\n| Old Test | Where is it covered
|\r\n| ------------- | ------------- |\r\n| should render the
description correctly | added description\r\nintegration on case view
activity page `should render the activity\r\ncontent and main
components` , text of the description is already\r\nverified
in\r\n`x-pack/plugins/cases/public/components/user_actions/description.test.tsx`\r\n|\r\n|
renders edit description user action correctly | Already
testing\r\ndescription create and update user actions in `renders user
actions\r\ncorrectly` in
file\r\n`x-pack/plugins/cases/public/components/user_actions/user_actions_list.test.tsx`\r\n|\r\n\r\n\r\nFixes
https://github.com/elastic/kibana/issues/151981\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [x] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"1d337e300f2de05cb356032f596318490f6d95e3","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Feature:Cases","v8.11.0","v8.12.0"],"number":170324,"url":"https://github.com/elastic/kibana/pull/170324","mergeCommit":{"message":"[Cases]
fix description user actions flaky test (#170324)\n\n## Summary\r\n\r\nI
removed the description user actions tests
from\r\n`x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx`\r\n\r\nThere
were a few things being tested:\r\n\r\n| Old Test | Where is it covered
|\r\n| ------------- | ------------- |\r\n| should render the
description correctly | added description\r\nintegration on case view
activity page `should render the activity\r\ncontent and main
components` , text of the description is already\r\nverified
in\r\n`x-pack/plugins/cases/public/components/user_actions/description.test.tsx`\r\n|\r\n|
renders edit description user action correctly | Already
testing\r\ndescription create and update user actions in `renders user
actions\r\ncorrectly` in
file\r\n`x-pack/plugins/cases/public/components/user_actions/user_actions_list.test.tsx`\r\n|\r\n\r\n\r\nFixes
https://github.com/elastic/kibana/issues/151981\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [x] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"1d337e300f2de05cb356032f596318490f6d95e3"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170324","number":170324,"mergeCommit":{"message":"[Cases]
fix description user actions flaky test (#170324)\n\n## Summary\r\n\r\nI
removed the description user actions tests
from\r\n`x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx`\r\n\r\nThere
were a few things being tested:\r\n\r\n| Old Test | Where is it covered
|\r\n| ------------- | ------------- |\r\n| should render the
description correctly | added description\r\nintegration on case view
activity page `should render the activity\r\ncontent and main
components` , text of the description is already\r\nverified
in\r\n`x-pack/plugins/cases/public/components/user_actions/description.test.tsx`\r\n|\r\n|
renders edit description user action correctly | Already
testing\r\ndescription create and update user actions in `renders user
actions\r\ncorrectly` in
file\r\n`x-pack/plugins/cases/public/components/user_actions/user_actions_list.test.tsx`\r\n|\r\n\r\n\r\nFixes
https://github.com/elastic/kibana/issues/151981\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n\r\n### For
maintainers\r\n\r\n- [x] This was checked for breaking API changes and
was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"1d337e300f2de05cb356032f596318490f6d95e3"}}]}]
BACKPORT-->

Co-authored-by: Janki Salvi <[email protected]>
delanni pushed a commit to delanni/kibana that referenced this issue Nov 6, 2023
## Summary

I removed the description user actions tests from
`x-pack/plugins/cases/public/components/case_view/components/case_view_activity.test.tsx`

There were a few things being tested:

| Old Test  | Where is it covered |
| ------------- | ------------- |
| should render the description correctly | added description
integration on case view activity page `should render the activity
content and main components` , text of the description is already
verified in
`x-pack/plugins/cases/public/components/user_actions/description.test.tsx`
|
| renders edit description user action correctly | Already testing
description create and update user actions in `renders user actions
correctly` in file
`x-pack/plugins/cases/public/components/user_actions/user_actions_list.test.tsx`
|


Fixes elastic#151981

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
6 participants