-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for VB runtime REVIEW 1ST #11863
base: main
Are you sure you want to change the base?
Add tests for VB runtime REVIEW 1ST #11863
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11863 +/- ##
===================================================
+ Coverage 75.42712% 75.52850% +0.10137%
===================================================
Files 3102 3118 +16
Lines 634244 636140 +1896
Branches 46866 46881 +15
===================================================
+ Hits 478392 480467 +2075
+ Misses 152434 152252 -182
- Partials 3418 3421 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
@paul1956 main is now .NET 10.0 alpha and I have synced main with feature/10.0. I also retargeted your PR to main. On each of your branches, I believe you only need to run command |
Replace redundent CloseProgressDialog
Add Tests for ExceptionUtils
…-Review-2nd-Feature-10
…tionDirectoryTests
Remove unneeded Paentheses Cleanup spacing Sort UnsafeNativeMethods
Clean up and correct all XML comments in ClipboardProxy (copy from System.Windows.Forms.Clipboard
like this :) |
@Tanya-Solyanik ready for review, thanks |
src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/Devices/NetworkAvailability.vb
Outdated
Show resolved
Hide resolved
...crosoft.VisualBasic.Forms/tests/UnitTests/System/Windows/Forms/SingleInstanceHelpersTests.vb
Outdated
Show resolved
Hide resolved
...crosoft.VisualBasic.Forms/tests/UnitTests/System/Windows/Forms/SingleInstanceHelpersTests.vb
Show resolved
Hide resolved
Correct VbMakeExceptionInvalidValuesTest_Succeed test
Fix formatting Move TestVbHost to separate file
Fix formatting
Paul - this PR is just too big to handle in one go. What is the one with the highest priority in your opinion and why. Please keep always in mind, we have limited resources, and this area, although important, doesn't have the highest priorities. |
@KlausLoeffelmann The changes to the actual network code is just splitting it up into about 10 pieces without code changes to make it easier to focus on getting rid of WebClient for download in the next PR. There are no logic changes in the VB Code in Microsoft.VisualBasic.Forms its almost all formatting which someone else can review. There is nothing in the PR that requires your review anymore. All the new network test code is in #12221. The next PR #11867 is where all the code changes happen to remove WebClient from NetworkDownload and all the Async code is added. Without the tests that is very risky. |
OK, I am losing a bit of track here, to be honest. |
Fixes #5179 and uses Fluent Assertions
Proposed changes
Add tests for
Assembly Public Key Is As Expected - used in other tests
Clipboard Proxy
Computer Info and Debug View
Enhance Control Tests to support new Project Level Options
A few Exception Tests more will be added with future PR
File IO Proxy Tests
Network Download
Single Instance Helpers
Temp Directory File Functions used by new tests
General new utilities use by tests
Time
User Tests
Web Listener Service
Customer Impact
Improve code quality via additional tests
Regression?
-No
Risk
Low - additional tests and code changes required to make them work
Test methodology
Visual Studio
Microsoft Reviewers: Open in CodeFlow