Split Network.VB into 7 Files from PR #11863

[paul1956]

Proposed changes

• Split Network.Vb in 7 files to prepare for replacement of WebClient for download

Customer Impact

• Developer only improvement

Regression?

• No

Risk

• Minimal all tests from Add tests for VB runtime Do Not Review #11863 pass

Microsoft Reviewers: Open in CodeFlow

[codecov]

Codecov Report

Attention: Patch coverage is 6.58784% with 553 lines in your changes missing coverage. Please review.

Project coverage is 75.63889%. Comparing base (d223c9e) to head (72a8f30).
Report is 5 commits behind head on main.

Additional details and impacted files

@@                 Coverage Diff                  @@
##                main      #12226          +/-   ##
====================================================
+ Coverage   49.20480%   75.63889%   +26.43409%     
====================================================
  Files           1985        3147        +1162     
  Lines         283954      635792      +351838     
  Branches       41730       47010        +5280     
====================================================
+ Hits          139719      480906      +341187     
- Misses        141535      151440        +9905     
- Partials        2700        3446         +746     

Flag	Coverage Δ
Debug	75.63889% <6.58784%> (+26.43409%)	⬆️
integration	18.23820% <0.00000%> (-0.01352%)	⬇️
production	49.16450% <6.58784%> (-0.04031%)	⬇️
test	97.03085% <ø> (?)
unit	46.14524% <6.58784%> (-0.04640%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[paul1956]

Reviewer note: coverage is identical to current unmodified code. The tests are in a separate PR #12221 .

[paul1956]

@KlausLoeffelmann there are no code changes in this PR, it just splits 1 large file into logical parts. Changes happen in follow on PR's. Having someone else do review might give you more time to work on other projects.

[paul1956]

@Tanya-Solyanik would it be possible to prioritize this PR over my others. It mostly splits 1 file into 7 using VS code fixes. There is also some cleanup of privates from m_name to _Name to follow updated .Net naming guidelines. It should be possible to eliminate most of the locals but that seemed to me like too big a change without the tests, which is a separate PR that is waiting for Klaus.

[paul1956]

@lonitra network.vb being completely rewritten in PR #11863 to replace WebClient which is obsolete. There are 3 separate (independent) pieces of functionality (upload, download and ping), in PR #11863 Async functions are also added in a separate file (PR review will decide if they ever become public). This allows the changes to be more isolated and the reviews simpler.

[lonitra]

LGTM 👍