Add tests for VB runtime also fixes #5179 and uses Fluent Assertions #11655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ightToLeft mode, both with VisualStyles enabled or disabled
# IDE0001: severity = silent # IDE0002: severity = silent
… and Network will be completely rewritten as part of code Cleanup PR
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/10.0 #11655 +/- ##
======================================================
+ Coverage 74.29395% 75.07733% +0.78338%
======================================================
Files 3026 3065 +39
Lines 627152 632677 +5525
Branches 46758 46784 +26
======================================================
+ Hits 465936 474997 +9061
+ Misses 157863 154311 -3552
- Partials 3353 3369 +16
Flags with carried forward coverage won't be shown. Click here to find out more. |
elachlan
added
the
waiting-review
lonitra
reviewed
Jul 11, 2024
| @@ -15,6 +15,7 @@ | |||
| namespace System.Windows.Forms.Tests; | |||
|
|
|||
| [Collection("Sequential")] | |||
| [CollectionDefinition("Sequential", DisableParallelization = true)] | |||
There was a problem hiding this comment.
I believe we had decided against this change in #11530
There was a problem hiding this comment.
@lonitra Then the test reliably fail. It might mean these tests need to move with your other Clipboard tests.
Don't know what to do with tests written in VB that fail without this.
Documentation says this forces tests in this class to run sequentially after all other tests.
src/Microsoft.VisualBasic/tests/UnitTests/Microsoft/VisualBasic/Devices/NetworkTests.cs
Outdated
Show resolved
Hide resolved
Split Network into 7 files by function and move to sub directory, no code changes. Cleanup XML Comment for Network code and update indenting to match C#
Simplify Dim New statements
[main] Update dependencies from dotnet/arcade
[main] Update dependencies from dotnet/runtime
Re-add condition to check drag image
[main] Update dependencies from dotnet/runtime
Correct logic in DriveProxyTest and FileNormalizePathTest_Success
[main] Update dependencies from dotnet/runtime
* Implement Control.Async. * Introduce Form.ShowAsync. * Introduce Form.ShowDialogAsync. * Introduce TaskDialog.ShowDialogAsync. * Fix setting correct TaskCompletionSource on Closing/Disposing. * Address review feedback.
Pulled from https://github.com/dotnet/winforms/pull/10985/files. Styling features and non-critical changes were stripped out to make this the smallest change possible.
- Move Experimental URL to DiagnosticIds - Move special dark mode logic from CreateBrushScope to GetSysColorBrush - Remove unnecessary logic in FindNearestColor - Update brushes and pens by poking SystemEvents static directly
Dark mode experimental feature
…dotnet#11785) * Add a manual test case for clones ListViewItem to WinformsControlsApp * Settle comments --------- Co-authored-by: Simon Zhao (BEYONDSOFT CONSULTING INC) <[email protected]>
|
Replaced by #11863 |
dotnet-policy-service
bot
removed
the
waiting-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests to VB Runtime (changes to ExceptionUtils, Utils and Network were unavoidable because of conflict between Utils conflicting with Utils.
Proposed changes
Add tests for
Assembly Public Key Is As Expected - used in other tests
Clipboard Proxy
Computer Info and Debug View
Enhance Control Tests to support new Project Level Options
A few Exception Tests more will be added with future PR
File IO Proxy Tests
Network Download
Single Instance Helpers
Temp Directory File Functions used by new tests
General new utilities use by tests
Time
User Tests
Web Listener Service
Customer Impact
Improve code quality via additional tests
Regression?
Risk
None - only additional tests
Test methodology
All the tests pass (though clipboard tests may fail randomly)
Test environment(s)
Visual Studio
Microsoft Reviewers: Open in CodeFlow