Adds code coverage to ClipboardProxy from PR #11863 #12227
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12227 +/- ##
===================================================
+ Coverage 75.42712% 75.43164% +0.00451%
===================================================
Files 3102 3103 +1
Lines 634244 634328 +84
Branches 46866 46868 +2
===================================================
+ Hits 478392 478484 +92
+ Misses 152434 152419 -15
- Partials 3418 3425 +7
Flags with carried forward coverage won't be shown. Click here to find out more. |
paul1956
changed the title
paul1956
changed the title
| Public Sub ClipboardProxy_ContainsText() | ||
| Dim clipboardProxy As New MyServices.ClipboardProxy | ||
| Dim text As String = GetUniqueText() | ||
| clipboardProxy.SetText(text) |
There was a problem hiding this comment.
Why do we need these tests? We are already establishing equivalency between the proxy and the Clipboard here https://github.com/dotnet/winforms/blob/4cd3b176bbfd0c48e526e40b761b7424499e8ee3/src/Microsoft.VisualBasic/tests/UnitTests/Microsoft/VisualBasic/MyServices/ClipboardProxyTests.cs
There was a problem hiding this comment.
@Tanya-Solyanik
I don't believe those actually use "MyServices" despite the name of the class. I also tests the things that are not tested in the other tests like audio. Note: the other tests don’t retry failures.
Tanya-Solyanik
added
the
📭 waiting-author-feedback
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
Fixes #
Proposed changes
Customer Impact
Regression?
Risk
Microsoft Reviewers: Open in CodeFlow