Decoder attr #609
Merged
Decoder attr #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sequencer
requested changes
May 26, 2024
| "vslide1up.vx", | ||
| "vslidedown.vx", | ||
| "vslideup.vx", | ||
| "lsu", |
| } | ||
|
|
||
| case class isAdder(value: TriState) extends BooleanDecodeAttribute { | ||
| override val description: String = "goes to [[org.chipsalliance.t1.rtl.LaneAdder]]." |
There was a problem hiding this comment.
Please provide a better documentation
|
|
||
| def y(t1DecodePattern: T1DecodePattern): Boolean = { | ||
| val allMatched = Seq( | ||
| "vcompress.vm", |
There was a problem hiding this comment.
all of them are same, please dedup
sequencer
requested changes
May 26, 2024
| case (fn, tri) if fn(t1DecodePattern) => isFloatmul(tri) | ||
| }.get | ||
|
|
||
| def y(t1DecodePattern: T1DecodePattern): Boolean = { |
There was a problem hiding this comment.
it should guarded by fp enabled, it can be accessed by T1DecodePattern.instruction
Lucas-Wye
force-pushed
the
decoder-attr
branch
3 times, most recently
from
de6c45d to
9acd11a
Compare
sequencer
force-pushed
the
decoder-attr
branch
3 times, most recently
from
32c7a5c to
a9ee870
Compare
sequencer
force-pushed
the
decoder-attr
branch
3 times, most recently
from
72ff5e8 to
67110a2
Compare
Lucas-Wye
force-pushed
the
decoder-attr
branch
2 times, most recently
from
884731f to
bc191b1
Compare
SpriteOvO
force-pushed
the
decoder-attr
branch
2 times, most recently
from
c5bde54 to
fddef3c
Compare
sequencer
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.