This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Forbid import when tensorflow
is not installed
#186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
See brainglobe/BrainGlobe#27 - this PR is for
conda-forge
compatibility reasons.What does this PR do?
This PR forbids the import of
cellfinder_core
whentensorflow
is not installed.Note that we do not need to remove
tensorflow
from thepyproject.toml
dependencies - these are read only bypip
and not byconda
.References
Resolves step 1 of this issue.
How has this PR been tested?
Local testing of
pip
package install:Is this a breaking change?
No. New version, PyPI upload, and conda-forge recipe required though.
Does this PR require an update to the documentation?
Updates README to explain that the conda-install will not fetch tensorflow, this will have to be done by the user.
Requires a change on
brainglobe-meta
repository.Checklist: