Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tools provided #15

Merged
merged 7 commits into from
Jul 18, 2023
Merged

Update tools provided #15

merged 7 commits into from
Jul 18, 2023

Conversation

willGraham01
Copy link
Collaborator

@willGraham01 willGraham01 commented Jul 3, 2023

Description

Waiting on:

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Allows the command

pip install brainglobe

to install all currently-available BrainGlobe tools, and makes the tools exposed to users compatible with a conda install.

Also enables step 3 of brainglobe/BrainGlobe#27.

What does this PR do?

References

Resolves the brainglobe-meta task in brainglobe/BrainGlobe#27.

How has this PR been tested?

Local testing of new import guards via pip installation.

Is this a breaking change?

No.

It also means there's no longer any need for the optional morphapi and cellfinder dependencies to be specified.

Does this PR require an update to the documentation?

Install instructions have been updated to reflect the pip install manifest and the (to be completed) conda-forge recipe.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -20.77 ⚠️

Comparison is base (b2ad646) 90.00% compared to head (ea3a5ce) 69.23%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #15       +/-   ##
===========================================
- Coverage   90.00%   69.23%   -20.77%     
===========================================
  Files           1        2        +1     
  Lines          20       26        +6     
===========================================
  Hits           18       18               
- Misses          2        8        +6     
Impacted Files Coverage Δ
brainglobe/_tensorflow_handle.py 62.50% <62.50%> (ø)
brainglobe/__init__.py 72.22% <75.00%> (-17.78%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@willGraham01 willGraham01 requested a review from a team July 4, 2023 15:51
@willGraham01 willGraham01 force-pushed the optional-packages-update branch from 81e7d30 to 330e23a Compare July 4, 2023 15:56
@willGraham01 willGraham01 marked this pull request as ready for review July 17, 2023 10:05
@alessandrofelder alessandrofelder merged commit dc06aaf into main Jul 18, 2023
@alessandrofelder alessandrofelder deleted the optional-packages-update branch July 18, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants