Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt noarch_platforms build #14

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Attempt noarch_platforms build #14

merged 2 commits into from
Jul 10, 2023

Conversation

willGraham01
Copy link
Contributor

@willGraham01 willGraham01 commented Jul 5, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Do not merge until cellfinder-core version is updated (see this checklist)

Once ready:

As suggested in #13, we can try to make use of noarch_platforms builds to ship a functional package on as many OSes as possible.

Currently only Windows has the tensorflow incompatibility issue, unix operating systems appear to be able to fetch tensorflow just fine. So we can specify a "unix-only" dependency of tensorflow, which should allow us to ship a working package on those platforms.

Windows installs will retain a broken package though. Also all the final checks can only pass on unix for the same reason, so they've been scoped to unix only.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@willGraham01
Copy link
Contributor Author

@conda-forge-admin please rerender

Copy link
Member

@adamltyson adamltyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

recipe/meta.yaml Show resolved Hide resolved
@willGraham01 willGraham01 mentioned this pull request Jul 10, 2023
3 tasks
@willGraham01
Copy link
Contributor Author

@adamltyson can you hit merge? I don't have write access to this repo as I'm not a maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG?] Versions >=0.4.0 cannot be installed using only conda-forge channels
2 participants