-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG?] Versions >=0.4.0 cannot be installed using only conda-forge channels #13
Comments
Based on this page it looks like TensorFlow is kinda no-longer supported on Windows (at least using a GPU). Can we specify the cpu version for Windows (and is that available?). |
We can't install any tensorflow version above 2.0.0 using only conda channels on Windows, and cellfinder-core requires at least v2.5.0. In turn, it means that anything that depends on cellfinder-core>=0.4.0 can't be conda-installed on Windows, since conda installs can only use conda channels to fetch dependencies. There's this hack that I've employed for the meta-package that (seems) to work; since cellfinder-core v3.1.0 didn't actually install tensorflow, so conda can resolve the dependencies and "install" the package. Then the manual pip-install trick I described needs be done by users manually to get it to work. Far from an ideal solution. |
Anything that has a hard dependency on tensorflow cannot be installed using only To fix this, we need to build tesnsorflow at conda-forge, but this isn't really easy. PRs welcome at the tensorflow feedstock. |
@willGraham01 I think we can make TF optional for now. It will also make downloads much quicker for most users (TF is only used for cellfinder). |
Conda-forge doesn't allow optional dependencies - TF is either in or out. TF is also a hard dependency of Couple of options:
Happy to proceed with either option. The latter is safer but will be touching a lot of our existing packages (and might temporarily break things). Former option is quick but not very safe (and I'm not sure what the conda-forge review team will say if we put a package up with no tests!) |
I think this is probably the best. None of the options seem particularly satisfactory though! |
Sadly the real blocker appears to be conda-forge itself. Everything we have is completely fine if Am going to move/link this issue onto |
What about reverting back from being a |
Would that make all the upstream dependencies linux and macOS only though? |
You could specify platform-dependent dependencies in dependent packages, e.g. in a brainglobe meta package you could specify something like |
I guess that also leaves certain users (potentially unknowingly) without some I guess it's which evil do you want:
|
This gets my vote. Most users will be using BrainGlobe tools via napari plugins, so this would mean the tools are visible, and we can provide explicit instructions on how to get them working. |
You may want to consider Discussion here: |
Thanks for the suggestion Mark!
With #14,
So with these changes to |
Comment:
Version
>=0.4.0
is noarch, and depends on tensorflow>=2.5.0
.However, only version 1.14.0 of tensorflow is available via conda-forge for Windows OSs (this appears to conflict with the claims of the tensorflow-feedstock badges though, but conda cannot locate any versions on Windows above 1.14.0).
This means that any packages to be uploaded to conda-forge that require cellfinder-core >=0.4.0 have unresolvable dependencies on Windows.
Workarounds
For conda-forge recipes: forcing Windows to use cellfinder-core<0.4.0 will bypass the issue but leave the user with a broken package, unless they follow the step below to install a compatible version of tensorflow first. This also makes any recipes illegible for noarch.
A compatible version of tensorflow can be installed via pip on Windows, so it is possible to install cellfinder-core>=0.4.0 manually by:
pip install tensorflow
conda install cellfinder-core>=0.4.0
But of course, conda-forge recipes cannot use non-conda channels, so this is not available when uploading new recipes to
staged-recipes
.The text was updated successfully, but these errors were encountered: