Foundations / Installation Overview: Preliminary WSL2 Introduction #25402

xandora · 2023-04-29T20:55:27Z

Include preliminary introduction to WSL2.

Because

It's about time we include WSL2 as an option for learners to work their way through the curriculum.

This PR

Sets a base branch for collaboration to start including WSL in the lessons.
Will touch on the following lessons:
- Installation Overview
- ...

Issue

Additional Information

Pull Request Requirements

I have thoroughly read and understand The Odin Project Contributing Guide
The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
The Because section summarizes the reason for this PR
The This PR section has a bullet point list describing the changes in this PR
If this PR addresses an open issue, it is linked in the Issue section
If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
If any lesson files are included in this PR, they follow the Layout Style Guide

Include preliminary introduction to WSL2.

KevinMulhern · 2023-04-29T22:39:25Z

Whoops, sorry @xandora, just noticing this is in draft. Would you like a reviewer assigned yet or do you have a bit more to do before it's ready for review?

xandora · 2023-04-29T23:32:56Z

Whoops, sorry @xandora, just noticing this is in draft. Would you like a reviewer assigned yet or do you have a bit more to do before it's ready for review?

It's very very draft, I just wanted a PR to point people to from the beta channel to kick off the collaboration.

JoshDevHub · 2023-04-29T23:44:24Z

Lessons that need to be touched:

Installations Overview: The language on the section regarding Windows support and OS options will have to be updated
Foundations Installations: Will need to include WSL2 specific installation instructions
Text Editors: Will have to show how to use VSCode with WSL2. Introduce WSL-remote extension
Command Line Basics: Using the terminal with WSL2. This could just be about using the default Ubuntu terminal that comes with WSL2 Ubuntu, or it could include instructions on using WSL2 via the Windows Terminal.

At some point, it'll need to be communicated how to deal with filesystem difference and in particular, how to move files from Windows to WSL2's filesystem. This could be introduced when it's installed. I might think it's best to be put here in Links and Images, which is the first time learners would actually need to use this.

The rules and bot commands (hosted in other repos) will have to be updated as well. Probably want to have it so everything is rolled out together.

fortypercenttitanium

Looking good so far, I'm excited for this. Let me know if I can help by testing anything

codyloyd · 2023-06-05T19:51:46Z

I am going to remove the 'needs triage' label from this one to get it off of the list since it's still in draft... feel free to start pinging maintainers and/or add that label back when you're ready for a review here.

…l-inclusion

Asartea · 2023-07-31T08:53:15Z

@xandora I think all the relevant lessons have now been updated, so this should be ready for review once the merge conflicts are resolved

I can't find it to resolve it. 🙄

ManonLef · 2023-08-29T10:56:21Z

I have gone through my previous review and left the ones unresolved that seem to be missing from the file now. Feel free to resolve those if they have become obsolete.

ManonLef

I left a bit more general feedback, mostly involving the installation lesson and style/formatting.

Good job everyone!

foundations/installations/command_line_basics.md

foundations/installations/installation_overview.md

foundations/installations/installations.md

Co-authored-by: Manon <[email protected]>

01zulfi

Nothing to review from my side.

This is going to be a huge step forward in supporting windows; kudos to everyone contributing 🚀 🔥

foundations/html_css/html-foundations/links-and-images.md

thatblindgeye · 2023-09-09T11:38:53Z

foundations/html_css/html-foundations/links-and-images.md

+
+2.  Next, download [this image](https://unsplash.com/photos/Mv9hjnEUHR4/download?force=true&w=640).
+
+3.  Right click on the new download at the bottom of the chrome window and select "Show in folder".


Not a blocker, but could be good to include instructions if a user doesn't have this enabled. "Alternatively, open the "Customize and control Google Chrome" kebab menu and select the "Downloads" item. This will show all of your downloads, each with its own "Show in folder" button."

Forgot to reply to this, but this is ✅ Done

thatblindgeye · 2023-09-09T11:41:41Z

foundations/html_css/html-foundations/links-and-images.md

+
+4.  Drag the file from your downloads folder to VSCode's file browser into your new `images` directory.
+
+Dragging files from Windows into the VSCode file browser prevents the `Zone.Identifier` files from being copied over. From now on, any time you need to copy pictures or other downloaded files like this into WSL, you can do it in this way. If you ever accidentally copy these `Zone.Identifier` files into WSL, you can safely delete them without any issue.


I feel like we should still include some alternative instructions to drag and drop, even it means warning that copy pasting or whatever other way may result in a (harmless) duplicate file.

There's a small amount of dragging and dropping with the alternative:

Using your Ubuntu terminal, navigate to the folder you want to copy the image to (cd ~/odin-links-and-images for example)

Type cp <space>

Drag the dog.jpg image from a Windows Explorer window and drop it onto the terminal window, it should appear as "/mnt/c/users/username/Downloads/dog.jpg"

Type <space> . to tell cp that you want to copy the file to your current working directory

The full command will look something like cp "/mnt/c/users/username/Downloads/dog.jpg" .

Hit to complete the command, and use ls to confirm the file now exists

The alternative alternative is to just do this:

Copy the file in Windows Explorer

In Windows Explorer, navigate to Linux > > /home//etc

Paste the file in that folder

This does get the :Zone.Identifier file, but doesn't use drag 'n drop

Maybe the solution is as simple as updating the verbiage to "Either drag and drop or copy and paste..." or something

Added the extra explanation by @xandora , which I think should be enough. If we see that lots of learners on Discord run into issues at this step we can always add extra instructions

foundations/installations/command_line_basics.md

foundations/installations/installation_overview.md

foundations/installations/text_editors.md

thatblindgeye · 2023-09-09T11:53:11Z

@xandora despite the number of comments above 🎉 🔥 🚀 on this content! 😆

Asartea · 2023-09-11T14:07:43Z

Will try to get to the comments either today or tomorrow

Co-authored-by: Eric Olkowski <[email protected]>

Asartea · 2023-09-21T17:35:53Z

Will try to get to the comments either today or tomorrow

Okay, so that was a lie, but I think I should have gotten all your comments @thatblindgeye

Asartea · 2023-10-01T13:26:22Z

Pokes @thatblindgeye

thatblindgeye

Left a reply to convo above, but I don't think it's a blocker at the moment. "Drag and drop this file..." may be synonymous to "copy and paste..." to users.

Asartea · 2023-10-11T07:59:25Z

I think it should be okay to merge at this point. Hopefully, we have gotten every major issue fixed, and if anything minor pops up we can always fix it later

foundations/installations/installations.md

**DO NOT MERGE:** Depends on TheOdinProject/curriculum/pull/25402 ## Because - We're moving to support WSL2 ## This PR - Updates the rules file to refer to WSL as a supported OS ## Pull Request Requirements  - [x] I have thoroughly read and understand [The Odin Project Contributing Guide](https://github.com/TheOdinProject/theodinproject/blob/main/CONTRIBUTING.md) - [x] The title of this PR follows the `keyword: brief description of change` format, using one of the following keywords: - `Feature` - adds new or amends existing user-facing behavior - `Chore` - changes that have no user-facing value, refactors, dependency bumps, etc - `Fix` - bug fixes - [x] The `Because` section summarizes the reason for this PR - [x] The `This PR` section has a bullet point list describing the changes in this PR

Update installation_overview.md

84b141c

Include preliminary introduction to WSL2.

github-actions bot added Content: Foundations Involves the Foundations content Status: Needs Triage labels Apr 29, 2023

KevinMulhern requested review from a team, zachmmeyer, dm-murphy and fortypercenttitanium and removed request for a team, zachmmeyer and dm-murphy April 29, 2023 22:19

KevinMulhern assigned fortypercenttitanium Apr 29, 2023

KevinMulhern removed the request for review from fortypercenttitanium April 29, 2023 22:39

KevinMulhern unassigned fortypercenttitanium Apr 29, 2023

fortypercenttitanium reviewed May 1, 2023

View reviewed changes

Add WSL instructions to HTML foundations Links and Images

b20a9c8

codyloyd removed the Status: Needs Triage label Jun 5, 2023

Asartea and others added 5 commits July 21, 2023 20:32

update text-editors for WSL

0813506

added instructions on using WSL in command_line_basics.md

387c6da

Merge branch 'wsl-inclusion' of github.com:xandora/curriculum into ws…

0f51df9

…l-inclusion

Add WSL Chrome installation instructions

4498f05

Add WSL installation instructions

962de65

xandora requested a review from a team August 29, 2023 10:31

ManonLef reviewed Aug 29, 2023

View reviewed changes

Asartea and others added 2 commits August 29, 2023 17:31

Apply suggestions from code review

53806c5

Co-authored-by: Manon <[email protected]>

Apply suggestions from code review

238c977

Co-authored-by: Manon <[email protected]>

01zulfi approved these changes Sep 2, 2023

View reviewed changes

thatblindgeye requested changes Sep 9, 2023

View reviewed changes

Apply suggestions from code review

3f873b7

Co-authored-by: Eric Olkowski <[email protected]>

This was referenced Sep 15, 2023

WSL: Add WSL command TheOdinProject/odin-bot-v2#416

Merged

OS: Add generic OS command TheOdinProject/odin-bot-v2#417

Merged

!Windows Drop windows command TheOdinProject/odin-bot-v2#418

Merged

Asartea added 2 commits September 21, 2023 17:16

Merge branch 'main' into wsl-inclusion

19f6396

implement some extra instructions

5c009f5

Merge branch 'main' into wsl-inclusion

e2db87c

ManonLef mentioned this pull request Oct 3, 2023

HTML Boilerplate: Add terminal command for opening browser in WSL #26409

Closed

7 tasks

thatblindgeye approved these changes Oct 6, 2023

View reviewed changes

Merge branch 'main' into wsl-inclusion

192489d

Merge branch 'main' into wsl-inclusion

617be6b

01zulfi approved these changes Nov 17, 2023

View reviewed changes

Merge branch 'main' into wsl-inclusion

ed953f9

JoshDevHub reviewed Nov 17, 2023

View reviewed changes

foundations/installations/installations.md Outdated Show resolved Hide resolved

Update codeblock markdown

0ebd80d

xandora merged commit 2302043 into TheOdinProject:main Nov 30, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Foundations / Installation Overview: Preliminary WSL2 Introduction #25402

Foundations / Installation Overview: Preliminary WSL2 Introduction #25402

xandora commented Apr 29, 2023

KevinMulhern commented Apr 29, 2023

xandora commented Apr 29, 2023

JoshDevHub commented Apr 29, 2023

fortypercenttitanium left a comment

codyloyd commented Jun 5, 2023

Asartea commented Jul 31, 2023

ManonLef commented Aug 29, 2023

ManonLef left a comment

01zulfi left a comment

thatblindgeye Sep 9, 2023

Asartea Oct 7, 2023

thatblindgeye Sep 9, 2023

xandora Sep 20, 2023

Asartea Sep 21, 2023

thatblindgeye Oct 6, 2023

Asartea Oct 7, 2023

thatblindgeye commented Sep 9, 2023

Asartea commented Sep 11, 2023

Asartea commented Sep 21, 2023

Asartea commented Oct 1, 2023

thatblindgeye left a comment

Asartea commented Oct 11, 2023


		2. Next, download [this image](https://unsplash.com/photos/Mv9hjnEUHR4/download?force=true&w=640).

		3. Right click on the new download at the bottom of the chrome window and select "Show in folder".


		4. Drag the file from your downloads folder to VSCode's file browser into your new `images` directory.

		Dragging files from Windows into the VSCode file browser prevents the `Zone.Identifier` files from being copied over. From now on, any time you need to copy pictures or other downloaded files like this into WSL, you can do it in this way. If you ever accidentally copy these `Zone.Identifier` files into WSL, you can safely delete them without any issue.

Foundations / Installation Overview: Preliminary WSL2 Introduction #25402

Foundations / Installation Overview: Preliminary WSL2 Introduction #25402

Conversation

xandora commented Apr 29, 2023

Because

This PR

Issue

Additional Information

Pull Request Requirements

KevinMulhern commented Apr 29, 2023

xandora commented Apr 29, 2023

JoshDevHub commented Apr 29, 2023

Lessons that need to be touched:

fortypercenttitanium left a comment

Choose a reason for hiding this comment

codyloyd commented Jun 5, 2023

Asartea commented Jul 31, 2023

ManonLef commented Aug 29, 2023

ManonLef left a comment

Choose a reason for hiding this comment

01zulfi left a comment

Choose a reason for hiding this comment

thatblindgeye Sep 9, 2023

Choose a reason for hiding this comment

Asartea Oct 7, 2023

Choose a reason for hiding this comment

thatblindgeye Sep 9, 2023

Choose a reason for hiding this comment

xandora Sep 20, 2023

Choose a reason for hiding this comment

Asartea Sep 21, 2023

Choose a reason for hiding this comment

thatblindgeye Oct 6, 2023

Choose a reason for hiding this comment

Asartea Oct 7, 2023

Choose a reason for hiding this comment

thatblindgeye commented Sep 9, 2023

Asartea commented Sep 11, 2023

Asartea commented Sep 21, 2023

Asartea commented Oct 1, 2023

thatblindgeye left a comment

Choose a reason for hiding this comment

Asartea commented Oct 11, 2023